Problem/Motivation

Reloading the page wipes out all existing filters.
Using the back button goes back to whatever page you were on before, not a previous filter state
Currently clicking on any pager links appends #0 to the URL

Steps to reproduce

Proposed resolution

Fix/improve this somehow

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3281217

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim.plunkett created an issue. See original summary.

bnjmnm made their first commit to this issue’s fork.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented

It looks like there's a Gist of how someone provided similar functionality in their own Svelte app. In this case, it would be more appropriate to use sessionStorage instead of localStorage, but the approach is pretty much the same.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: Unassigned » hooroomoo
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Issue tags: +Project Browser MVP

hooroomoo opened merge request !107

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented

There are some bugs to work out that I'll continue tom

srishtiiee made their first commit to this issue’s fork.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Issue tags: +Needs tests

hooroomoo opened merge request !112

hooroomoo closed merge request !107

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Active » Needs review
Issue tags: -Needs tests
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented

Needs bug fixing after rebasing, will continue tomorrow

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

I tried to rebase this but I got lost as there are conflicts in the ProjectBrowserUiTest that I don't understand.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: hooroomoo » Unassigned
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Reviewed & tested by the community

Code and demo looks good. Unearthed the idea that this app is not very non-pointer friendly, but am opening that as a follow-up.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Had to fix a complication caused by #3283683: Linting doesn't run when only files in the sveltejs are changed, but was able to merge this cleanly. Thanks @hooroomoo for the excellent work on this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.