The "Included modifiers" listed on the project page include a Lowercase feature, which exists in version 7, but not in version 8.

CommentFileSizeAuthor
#9 interdiff_3-8.txt1.05 KBsonnykt
#3 token_modifier-3280023-3.patch816 bytesalan.cole
#2 token_modifier-3280023-1.patch810 bytesalan.cole

Issue fork token_modifier-3280023

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alan.cole created an issue. See original summary.

alan.cole’s picture

alan.cole commented
StatusFileSize
new token_modifier-3280023-1.patch810 bytes
alan.cole’s picture

alan.cole commented
StatusFileSize
new token_modifier-3280023-3.patch816 bytes

Update to previous patch - fixed the module name in namespace.

alan.cole’s picture

alan.cole commented
Status: Active » Needs review
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Needs manual testing

I've confirmed the patch applies cleanly to the D8 branch and only makes the desired change:

[token_modifier/8.x-1.x] [token_modifier]$ git status
On branch 8.x-1.x
Your branch is up to date with 'origin/8.x-1.x'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/Plugin/token_modifier/Lowercase.php

And the code looks nice and clean.

Just need someone to test this manually so tagging.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

I do see unit tests in tests/src/Unit so not sure if a test needs to be added for this.

sonnykt made their first commit to this issue’s fork.

sonnykt opened merge request !1

sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented
StatusFileSize
new interdiff_3-8.txt1.05 KB

Converted patch #3 into a merge request with unit test.

chike’s picture

chike
Primary language English
Location Nigeria
commented

Patch #3 is working. Thanks.

jofitz made their first commit to this issue’s fork.

  • jofitz committed 14f105fc on 2.0.x authored by sonnykt 
    Issue #3280023 Added "Lowercase plugin" and unit test.
jofitz’s picture

jofitz
he/him
commented
Version: 8.x-1.0-alpha2 » 2.0.x-dev
Assigned: alan.cole » jofitz
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Thanks for the Unit Tests, @sonnykt

jofitz’s picture

jofitz
he/him
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.