Problem/Motivation

to be completed after 3278972 is merged

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3280006

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

run fast think slow -lets4- created an issue. See original summary.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented

++ When https://www.drupal.org/project/project_browser/issues/3279510 is merged as this will use the plugin to generate fixture.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Assigned: Unassigned » chrisfromredfin

Working on this now

chrisfromredfin opened merge request !118

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Active » Needs review

bnjmnm made their first commit to this issue’s fork.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Fixed

Fresh fixture + some needed corrections 👍

  • tim.plunkett committed c91276c on 1.0.x 
    Revert "Issue #3280006 by chrisfromredfin: May 2022 - Update Fixture"...
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Fixed » Needs work

Reverted, this broke PB from loading

fjgarlin’s picture

fjgarlin commented
Assigned: chrisfromredfin » fjgarlin

fjgarlin opened merge request !137

fjgarlin’s picture

fjgarlin commented

The only thing left is to re-generate the full fixture. On it.

fjgarlin’s picture

fjgarlin commented
Status: Needs work » Needs review

Please review this with the new fixtures and changes. Hopefully the code is cleaner now and the "translations" are in the right place. The text fixtures also matches the one of the main module too.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

Good that we've got some tests for this as well. Thanks for the assist (well, save!) Fran!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.