Problem/Motivation

Fran went through and initially thought the following components are no longer in use. If that's the case we should remove.

Initial list to evaluate:

  • Project/LastUpdated.svelte
  • Project/Releases.svelte
  • Project/SupportingOrganization.svelte
  • Project/TaxonomyTerm.svelte
  • Project/Usage.svelte
  • CloseButton.svelte
  • DownloadPopup.svelte
  • Sort.svelte

Steps to reproduce

Latest/HEAD of 1.0.x

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Evaluate each suggestion for usage
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 after.png30.03 KBlibbna
#6 before.png39.55 KBlibbna

Issue fork project_browser-3279983

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue summary: View changes

Project/LastUpdated.svelte - we're not showing this in the UI - this was something we originally has considered about but no longer are interested in for MVP

Project/Releases.svelte - not currently used, but this is something we may want on the detail page in phase 2 if we want to get/show ALL the releases, but I'm not sure we do so we can eliminate for now. Can always resurrect from git history if we need it.

Project/SupportingOrganization.svelte - not used and not MVP

Project/TaxonomyTerm.svelte - not used

Project/Usage.svelte - not used, the usage stats are coded right in from the API call in ProjectListView.svelte - CAN GO

CloseButton.svelte- used by Modal.svelte as the Close Button

DownloadPopup.svelte - used by ActionButton

Sort.svelte - used in ProjectGrid.svelte and exported

fjgarlin’s picture

fjgarlin commented
Assigned: Unassigned » fjgarlin

fjgarlin opened merge request !75

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review
libbna’s picture

libbna commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before.png39.55 KB
new after.png30.03 KB

Reviewed the MR and mentioned unused Svelte files are removed. Added screenshots for proof.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.