Problem/Motivation

The bundle files that are built by svelte are not really readable, and they are not handled well by git diff, even Gitlab's version.
Apparently Gitlab has quietly adopted Github's approach to suppressing these, though it's not documented well

Steps to reproduce

View any MR that changes the build files, notice how they either never load or are illegible once they do

Proposed resolution

Add .gitattributes to hide them from Gitlab UI

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

Unfortunately either this isn't going to work, or it needs to be committed before working. Going to do so now and test, will revert and regroup if it doesn't work

  • tim.plunkett committed 8f66648 on 1.0.x
    Issue #3279918 by tim.plunkett: Suppress built files in Gitlab MR via ....

tim.plunkett’s picture

tim.plunkett’s picture

Status: Active » Fixed

Got this working with help from @fjgarlin. So much nicer now!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.