Meeting will happen in #d10readiness on drupal.slack.com.
Hello and welcome to this Drupal 10 readiness meeting!
This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Now happens every Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3278282`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.| Björn Brala (bbrala) | Björn, Netherlands, jsonapi. |
| ijf8090 | Ian Finlay (ijf8090) recent DrupalEasy graduate, interested in D10 |
| Kristen Pol (she/her) | Kristen, California |
| andypost | Andy, interwebs |
| Ilcho Vuchkov (vuil) | Ilcho Vuchkov, Bulgaria (EU) |
| Warped | Dave in Chicago |
| shaal | Ofer Shaal, late... |
| Kristen Pol (she/her) | Looking for resources used to organize and run contribution events in order to encourage some d10readiness contribution events to happen soon https://www.drupal.org/community-initiatives/contribution-events-initiat... |
| andypost | Module deprecation still has a question of composer façade, should it wait for 9.4 release to deprecate color, aggregator and so on? |
| larowlan | Any updates on composer facade changes for former core modules eg aggregator |
| larowlan | Oh Andy already asked that |
| Gábor Hojtsy (he/him) | Topic raised by @Kristen Pol (she/her) |
| Gábor Hojtsy (he/him) | Actually it was you @Kristen Pol (she/her) who posted this detailed guide for Drupal 9: http://www.kristen.org/content/preparing-yourself-drupal-9-porting-weekend |
| Gábor Hojtsy (he/him) | I think a similar situation applies to Drupal 10, it would be the same tools |
| andypost | Interesting if d-org needs change to display field for d10 readiness and what should be done for d9-compatibility field for projects |
| Gábor Hojtsy (he/him) | @andypost the Drupal 9 compatibility values were already wiped and replaced with Drupal 10 compatibility plans months ago :slightly_smiling_face: (edited) |
| Kristen Pol (she/her) | Yeah, that was a good one :D But also curious about the planning stuff. Like spreadsheets, how it was advertised, etc. It seems like this stuff is usually kind of organic but it would be good to document some ways of planning that worked for these events. Ideally I'd love to create “playbooks” on how to plan different types of events (edited) |
| Gábor Hojtsy (he/him) | I also did a quickstart guide, see https://www.hojtsy.hu/blog/2020-jan-15/drupal-9-compatibility-contributi... |
| Gábor Hojtsy (he/him) | For process organization, I announced the D9 porting weekend at https://groups.drupal.org/node/535946 with a few mentors and a call for mentors, then signed up further mentors. I think people were pumped to fill in the gaps in the timeline. |
| Gábor Hojtsy (he/him) | (visualizing it helped) |
| Kristen Pol (she/her) | Thanks!!! That's very helpful. I'll work on getting these resources into the docs :+1: |
| Kristen Pol (she/her) | I've added these resources to https://www.drupal.org/community-initiatives/contribution-events-initiat... |
| Gábor Hojtsy (he/him) | @andypost raised this |
| Gábor Hojtsy (he/him) | I was not clear on which one should wait in terms of what on which one? |
| hestenet (he/him) | Relevant to @mixologic |
| mixologic | Im trying to solve them all at once |
| mixologic | and make it so that we dont have any issues with moving them into/out of core again. |
| andypost | @mixologic as we are in 9.4-alpha I think it could be possible since release? |
| mixologic | Im not sure what you are suggesting |
| mixologic | that we can, or cant remove them? |
| andypost | At least beta stage does not allow to deprecate, that's why I bet we should wait for 9.4 release before continuing |
| mixologic | So are those modules removed from core and deprecated? I thought that was the case |
| mixologic | or are we waiting for them to exist at the facade before we do that? |
| andypost | Only aggregator is deprecated but I created contrib color module to allow deprecation but it still does not report it, so I changed its name https://git.drupalcode.org/project/color/-/commit/fa846ffd64c143bf713aae... (edited) |
| andypost | @mixologic is there issue to follow/comment about it in infra somewhere? |
| mixologic | There preobably should be. I was doing research to figure out the best way to go about this, and then was going to create one once I knew what the plan was |
| Gábor Hojtsy (he/him) | @larowlan raised the same |
| larowlan | Yep aggregator and quickedit are the two that are deprecated already |
| larowlan | Once 9.4 comes out people will have to run the deprecated one from core whilst we sort this out |
| andypost | There's #3280399: Mark drupal/core-bridge 9.5.x as abandoned which is looking like another case to handle |
| mixologic | ^ oh, thats interesting |
| Gábor Hojtsy (he/him) | My attempts to run drupalci locally again failed miserably unfortunately |
| hestenet (he/him) | Maybe @mglaman can help us with this.. |
| Gábor Hojtsy (he/him) | See https://drupal.slack.com/archives/C223PR743/p1652117102170949 for my trials a week ago :confused: |
| mglaman | :eyes: |
| mglaman | brew install vagrant let’s go go go! |
| mglaman | let me give it a whirl, finally |
| hestenet (he/him) | :thankful: |
| mglaman | I keep forgetting and saying “yeah, I’ll get it updated on personal computer because I ran it there before…” but never get to it. So running a fresh setup on work laptop |
| mglaman | lol it wants to reboot my macos :sob: |
| hestenet (he/him) | :disappointed: |
| mglaman | flipped to personal computer, got vagrant updated |
| mglaman | okay, box importing. we'll see what happens next! |
| mglaman | egh I think new macOS permissions are breaking it, can't open a network interface |
| Gábor Hojtsy (he/him) | For me, the IP was not within the allowed range, but adjusting that fixed that part. The other problems though I could not fix. |
| Gábor Hojtsy (he/him) | https://git.drupalcode.org/project/infrastructure/-/tree/main/stats/proj... are the original “integration tests”, although these are more like examples from the time, the codebase also has some actual tests, but I did not find docs on how to run them (edited) |
| Björn Brala (bbrala) | When running you also need to update the vbox guest additions. This means; adding a cdrom, mounting the guest additions, then starting the installation from /media/cdrom |
| Björn Brala (bbrala) | Virtualbox is annoying though everywhere. Here its hyperv conflicting T_T |
| Warped | @Björn Brala (bbrala) Are you on VirtualBox v5 or v6? I thought v6 was required for co-existing with HyperV. Upgrading v6 always asked if I also wanted to upgrade the guest edition. |
| Björn Brala (bbrala) | 6, seems hyper v was not really the problem I guess. But things like booting the vm was very slow waiting on problems with services. Then after updating the guest additions the network wasn't working and shared folder still didn't connect properly. Then I went to bed :sweat_smile: |
| Gábor Hojtsy (he/him) | Yeah I had the shared folder problem too :( |
| Björn Brala (bbrala) | Have you tried the vbguest plugin? That should at least streamline the guest additions install.I'll try and start it a few times today when I have the time. See if I can get it to work. |
| Björn Brala (bbrala) | Well, with hyperv disbled things seem to work (with vbguest plugin so that the gues additions are less effort). |
| Björn Brala (bbrala) | PS C:\projecten\drupalci_testbot> vagrant up Bringing machine 'drupalci' up with 'virtualbox' provider... ==> drupalci: Importing base box 'drupalci/testbot'... ==> drupalci: Matching MAC address for NAT networking... ==> drupalci: Checking if box 'drupalci/testbot' version '0.34.0' is up to date... ==> drupalci: Setting the name of the VM: drupalci_testbot_drupalci_1652770159068_32969 ==> drupalci: Clearing any previously set network interfaces... ==> drupalci: Preparing network interfaces based on configuration... drupalci: Adapter 1: nat drupalci: Adapter 2: hostonly ==> drupalci: Forwarding ports... drupalci: 22 (guest) => 2222 (host) (adapter 1) ==> drupalci: Running 'pre-boot' VM customizations... ==> drupalci: Booting VM... ==> drupalci: Waiting for machine to boot. This may take a few minutes... drupalci: SSH address: 127.0.0.1:2222 drupalci: SSH username: testbot drupalci: SSH auth method: private key drupalci: drupalci: Vagrant insecure key detected. Vagrant will automatically replace drupalci: this with a newly generated keypair for better security. drupalci: drupalci: Inserting generated public key within guest... drupalci: Removing insecure key from the guest if it's present... drupalci: Key inserted! Disconnecting and reconnecting using new SSH key... ==> drupalci: Machine booted and ready! [drupalci] No Virtualbox Guest Additions installation found. Reading package lists... Building dependency tree... Reading state information... dkms is already the newest version. linux-headers-4.9.0-0.bpo.6-amd64 is already the newest version. The following package was automatically installed and is no longer required: libuuid-perl Use 'apt-get autoremove' to remove it. 0 upgraded, 0 newly installed, 0 to remove and 3 not upgraded. Copy iso file C:\Program Files\Oracle\VirtualBox\VBoxGuestAdditions.iso into the box /tmp/VBoxGuestAdditions.iso Mounting Virtualbox Guest Additions ISO to: /mnt mount: /dev/loop2 is write-protected, mounting read-only Installing Virtualbox Guest Additions 6.1.32 - guest version is unknown Verifying archive integrity... All good. Uncompressing VirtualBox 6.1.32 Guest Additions for Linux........ VirtualBox Guest Additions installer Removing installed version 4.3.18 of VirtualBox Guest Additions... Copying additional installer modules ... Installing additional modules ... VirtualBox Guest Additions: Starting. VirtualBox Guest Additions: Building the VirtualBox Guest Additions kernel modules. This may take a while. VirtualBox Guest Additions: To build modules for other installed kernels, run VirtualBox Guest Additions: /sbin/rcvboxadd quicksetup VirtualBox Guest Additions: or VirtualBox Guest Additions: /sbin/rcvboxadd quicksetup all VirtualBox Guest Additions: Building the modules for kernel 4.9.0-0.bpo.6-amd64. update-initramfs: Generating /boot/initrd.img-4.9.0-0.bpo.6-amd64 Unmounting Virtualbox Guest Additions ISO from: /mnt ==> drupalci: Checking for guest additions in VM... ==> drupalci: Configuring and enabling network interfaces... ==> drupalci: Mounting shared folders... drupalci: /home/testbot/testrunner => C:/projecten/drupalci_testbot |
| Björn Brala (bbrala) | Next no internet. Lovely |
| Björn Brala (bbrala) | was dns so editied /etc/resolv.conf to use 8.8.8.8 |
| Björn Brala (bbrala) | o_O |
| Björn Brala (bbrala) | @Gábor Hojtsy (he/him), so since the runner seems to be working, what do you need :slightly_smiling_face: |
| Björn Brala (bbrala) | interesting to see how long a testrun will take :X |
| Björn Brala (bbrala) | AMD 5900x :heart: |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) https://git.drupalcode.org/project/infrastructure/-/tree/main/stats/proj... has a readme on how to run the bot locally :smile: it is a bit outdated but should get you some results nonetheless |
| Björn Brala (bbrala) | Ok cool. I'll see if I can get it running :man-running: |
| Björn Brala (bbrala) | Notes:checkout infrastructure in /var/lib/durpalci/workspacecp ~/infrastructure/stats/project_analysis/project_analysis_utils/tests/project_list_files/projects_machine_name.tsv /var/lib/drupalci/workspace/projects.tsvmkdir /var/lib/durpalci/workspace/phpstan_results/add: "sudo dpkg -i /var/lib/drupalci/workspace/infrastructure/stats/project_analysis/parallel_20190622_all.deb" to d9readyness.shAfter a run "rm -rf /var/lib/drupalci/workspace/drupal-checkouts/*"Can run ./dockerwrapper.sh then which executed d9readyness.sh, output for phpstan currently says "./vendor/bin/drush command not found"Thats the status right now :x |
| Björn Brala (bbrala) | Ok, i think im starting to understand. Things will run, but if i understand it correctly the docker directory in project_analysis builds https://hub.docker.com/r/drupalci/static_analysis/tags, which is used in https://dispatcher.drupalci.org/job/project_analysis_d10/ to deploy pod(s) for analysis (drupalci/static_analysis:9.4.x). Which attached all the phpstand results to an jenkins artifact. Those artifacts seem to only have projecten from the letter L and up, am i missing other projects? |
| Björn Brala (bbrala) | If i look at the dockerfile that is building the container, shoudn't something like this: && composer --working-dir=/var/lib/drupalci/drupal-checkout require palantirnet/drupal-rector:0.12.0 --dev \ be upgraded? Since 0.12.2 is released? Perhaps change to 0.12.* |
| Björn Brala (bbrala) | Also drush is built with a specific version (11.0.3) but 11.0.9 is the current? |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) the script I linked above has a minimal project list |
| Björn Brala (bbrala) | Yeah i had it running with only those projects |
| Björn Brala (bbrala) | although it errored on drush not being installed |
| Gábor Hojtsy (he/him) | 3-4 projects each :) |
| Gábor Hojtsy (he/him) | There are also tests but I did not find info on how to run those. It would probably be easiest to update the tests / fix the code and assume the rest will fall into place. |
| Björn Brala (bbrala) | I'm just trying to understand the tooling, which i seem to do at least basically. |
| Björn Brala (bbrala) | Next up is; what am i fixing lol |
| Björn Brala (bbrala) | Is there an issue? |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) #3279548: Drupal 9 to 10 project update bot code still produces Drupal 9 info files, need fixing so it can post again |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) this is run as part of the d10readiness.sh |
| Björn Brala (bbrala) | ok, this is not in the main branch yet is seems. |
| Björn Brala (bbrala) | @Gábor Hojtsy (he/him) the tests do some testing of that class. I wonder, for d10 readyness would it also handle a d8 requirement to '^8 || ^9 || ^10' if that is possible? |
| Björn Brala (bbrala) | so only file is d9readiness.sh, but perhaps that has just been repurposed...? |
| Björn Brala (bbrala) | Would this mean the whole check needs to be repurposed to reflect the same situation in d8 (8.8 + 9) but then in the d10 situation (9 || 10 or 9.5 || 10)? |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) I don't think we can ensure it is 8 compatible but if the info file says still 8 compatible and there was nothing to patch then we can keep that probably :) if rector generated something then it would not work with Drupal 8 |
| Gábor Hojtsy (he/him) | The d10 job runs var/lib/drupalci/workspace/infrastructure/stats/project_analysis/project_readiness.sh |
| Björn Brala (bbrala) | ahh :slightly_smiling_face: thanks |
| Gábor Hojtsy (he/him) | Per https://dispatcher.drupalci.org/job/project_analysis_d10/95/flowGraphTable/ |
| Björn Brala (bbrala) | lovely naming convention there lol |
| Björn Brala (bbrala) | but thanks, then i can run it locally also with docker it seems. |
| Björn Brala (bbrala) | hehe this line in run_project.sh: /var/lib/drupalci/workspace/infrastructure/stats/project_analysis/d9readiness.sh |
| Björn Brala (bbrala) | just running the same as before i guess, fair enough. (edited) |
| Gábor Hojtsy (he/him) | Yeah it's just checking out different versions of Drupal I think. |
| Gábor Hojtsy (he/him) | But it's not used as a Drupal 9 readiness job anymore (since November or so) so we can freely change to Drupal 10 and not bother with conditional logic. |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) I see you posted on the issue too :) tried to respond there as well :) happy to help as much as I can from here |
| Björn Brala (bbrala) | Sure, thanks, the specs of what needs to be done is a bit muddy to me :wink: |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) currently the bot code runs upgrade status, runs rector and then runs upgrade status again :slightly_smiling_face: it fixes the info file if the final run was empty (no incompatibilities found), the info file fixing would need to be updated to not make it 8/9 compatible which it does now but 10 instead :slightly_smiling_face: since the rector rules got in already, the rector part of the logic part otherwise does not need fixing IMHO, just the info part |
| Björn Brala (bbrala) | yeah but the current tests also test some of the results when there is incompatibilities on different versions of Drupal. Although I do see some real results in the artifact last run (3 days ago) so i guess i could use those.The change to the info yml logic is kinda easy, fixing the tests to make sure it doesn't upgrade something that is not compatible is little less straightforward.Although, perhaps im overthinking things, think i just need to check the support window for the versions... whats the minimum 9 version it would add to the info.yml? 9.4 I think?Think that is the basis of my confuusion right now.Add 10 if possible is clearIf the module support ^9.0 right now, what version would be make it then? In the current code it could end up making it 8.7.6 || 9 or 8.8 || 9. This would probably translate to 9.3 || 10? Or should we just reuse the current 9 tag the module uses? Which could mean a non supported version.When the current version is ^8.8 and we have no problems in rector, would this mean the result is:^8.8 || ^9 || ^10 ?So as you might notice, the specs are not completely clear to me :wink: |
| Björn Brala (bbrala) | @Gábor Hojtsy (he/him) perhaps i should post this on the issue :confused: |
| Gábor Hojtsy (he/him) | posted about hte logic at #3279548: Drupal 9 to 10 project update bot code still produces Drupal 9 info files, need fixing so it can post again#comment-14530700, hope that is helpful? |
| Gábor Hojtsy (he/him) | I think the conditions and things being run exist, but the actual change to the info file needs to be slightly different, but new logic is not required(?) |
| Björn Brala (bbrala) | the logic does things like check minor core versions. |
| Björn Brala (bbrala) | ill show you the change, sec |
| Björn Brala (bbrala) | (btw i like slack more than the issue queue, although that is kinda dangerous :wink:) |
| Björn Brala (bbrala) | https://git.drupalcode.org/issue/infrastructure-3279548/-/compare/main..... |
| Björn Brala (bbrala) | There is quite some logic to check for minor versions of 8 in there. |
| Björn Brala (bbrala) | based on the deprecation messages in the rector files. |
| Gábor Hojtsy (he/him) | :open_mouth: |
| Björn Brala (bbrala) | So that kinda complicates things a little :wink: |
| Björn Brala (bbrala) | Posted on the issue; I could ofcourse ignore current setup and implement what you commented, but need a go on that by you then :grinning: |
| Gábor Hojtsy (he/him) | @tedbow came up with that detailed logic maybe he has feedback on where to go from there :) |
| Björn Brala (bbrala) | Good one, let's go team JSON bourne haha :wink: |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) ok looking at the code in more detail now, getMinimumCore8Minor() in the existing code only support 8.8 and 8.7 because 8.7.7 was when the core_version_requirement was introduced, I think the foreach could have [5, 4, 3, 2, 1] at this point. Looks like that would find the highest version number of deprecated APIs identified — pushed this entirely untested change now :smile: https://git.drupalcode.org/issue/infrastructure-3279548/-/commit/f5a0a74... |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) basically we need put aside the special logic of limiting to 8.7.7 earliest and trying to keep the core key optionally, since both of those were special cases in the 8 to 9 process, so then we can (a) keep the logic that we don’t undo any existing info file limits (b) we do try to identify the lowest new limit we need to set based on deprecated APIs identified (c) we remove the core key no matter what :smile: // hope this helps? |
| Björn Brala (bbrala) | Yeah that sounds like a plan |
| Björn Brala (bbrala) | just gonna need to extract for example stuff from the project update bot for the different versions to have tests that make sense |
| Björn Brala (bbrala) | but i got those files locally now for quite a few projects, so hopefully i can just pick and choose a few |
| Björn Brala (bbrala) | And thank you :wink: |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) I don’t think we need to test all the combinations, a few here and there should be fine IMHO |
| Gábor Hojtsy (he/him) | This is my updated understanding of the logic. |
| Björn Brala (bbrala) | yeah, ill think of a little set (edited) |
| Gábor Hojtsy (he/him) | the existing core version requirement checking is a bit brittle I think but we can put that probably in the “ask for forgiveness” bucket :smile: only a couple projects would be affected who use advanced composer constraints |
| Gábor Hojtsy (he/him) | also THANK YOU @Björn Brala (bbrala) |
| Björn Brala (bbrala) | Glad to help. I like unblocking people :wink: Pretty much my dayjob hehe. |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) when this lands and we can run the bot again that would be massively unblocking people to work on porting without the automatable bits :) |
| Björn Brala (bbrala) | Yeah, will try and make some time tonight to get the last few things fixed. After that i guess we just pray haha |
| tedbow | ok I got some reading to do. probably in an hour or so |
| Björn Brala (bbrala) | A lot of it was vagrantlocal testbot stuff though, which for this specific change regarding the info.yml didnt really matter. It did matter for the failing of the job on the cluster though, but i don't think you need to look into that :slightly_smiling_face: |
| tedbow | oh I meant I have to read this thread first |
| Björn Brala (bbrala) | Fair enough :) |
| Gábor Hojtsy (he/him) | I also just pushed a commit to update all the issue comment/summary templates in the bot to talk about Drupal 10. We probably want to publish another blog post before we run it which should be referenced instead of the Drupal 9 version, but otherwise those are ready for 10 IMHO. |
| Björn Brala (bbrala) | Thanks, yeah if there is a link it should be to the right place. |
| Björn Brala (bbrala) | @Gábor Hojtsy (he/him) are you around? |
| Björn Brala (bbrala) | I might be overthinking things, but something is not sitting right with me.What about modules that currently support Drupal 8.8 and have no deprecations but the info.yml. I would say they needs a new info.yml that contains "^8.8 || ^9 || ^10" |
| Björn Brala (bbrala) | Unless we forced those updates last time, those modules are gonna be around still, quite a few even. |
| Björn Brala (bbrala) | Hmm, never mind, the whole process will fail then since it only checks against Drupal 9 core. |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) around! I made a lot of commits :smile: removed a lot of unneeded files, especially phpstan.neon and rector yamls that were horribly outdated but also a lot of D8 to 9 scripts that we are not using anymore, so its less confusing |
| Gábor Hojtsy (he/him) | also made a lot of docs updates and removed two rector workarounds from the analyzer expecting we don’t need them anymore |
| Björn Brala (bbrala) | great, unfortunate that you are doing so much work now lol :stuck_out_tongue_winking_eye: |
| Gábor Hojtsy (he/him) | why? :smile: |
| Gábor Hojtsy (he/him) | ah, would have been easier to figure it out? :slightly_smiling_face: |
| Björn Brala (bbrala) | Nah, just was gonna help you out, and now you are still doing a lot of work. Which i thank you for hehe |
| Björn Brala (bbrala) | no worries :slightly_smiling_face: |
| Gábor Hojtsy (he/him) | well, I did not have anyone with a running version of this, and I still don’t have a running version so you tell me if I broke it :stuck_out_tongue: I don’t think I changed anything that would have |
| Björn Brala (bbrala) | The only thing broken outside infoupdater: 1) InfoUpdater\MachineNameFinderTest::testFindMachineName Undefined offset: 2 /home/localcopy/infrastructure/stats/project_analysis/project_analysis_utils/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php:113 -- |
| Björn Brala (bbrala) | but that was already broken before your changes :slightly_smiling_face: |
| Gábor Hojtsy (he/him) | so re your question I think this would append the 10 possibility to info files even if they were 8/9 compatible: // Only update if doesn't already satisfy 10.0.0, will only happen if $minimum_core_minor was 0. if (empty($new_core_version_requirement) && !Semver::satisfies('10.0.0', $info[static::KEY])) { $new_core_version_requirement = $info[static::KEY] . ' || ^10'; } |
| Björn Brala (bbrala) | this would result in |
| Björn Brala (bbrala) | "^8 || ^10" |
| Björn Brala (bbrala) | Should this happen in some way :) |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) ah, this script is only ever run on releases/codebases that declare themselves 9 compatible already |
| Björn Brala (bbrala) | which is quite the weird combo :stuck_out_tongue: |
| Gábor Hojtsy (he/him) | so that should not happen |
| Björn Brala (bbrala) | yeah, thats what i notices a little later, since the core version it tets against is d9 |
| Björn Brala (bbrala) | so it cannot install :slightly_smiling_face: |
| Gábor Hojtsy (he/him) | phpstan_send_d10 has thisWHERE prsv.supported = 1AND core_version_requirement REGEXP '[~^]9' |
| Björn Brala (bbrala) | great ^^ |
| Björn Brala (bbrala) | I noticed one fun unrelated error in the results btw |
| Gábor Hojtsy (he/him) | that regex may also find 8.9 as valid, but then as you noted, it will not install on Drupal 9.4.x which is what is being used |
| Björn Brala (bbrala) | yeah i found out because of the phpstan errors in teh resulset :) |
| Björn Brala (bbrala) | But this is what i mean, the testbot is missing an extension for commerce: |
| Björn Brala (bbrala) | ./composer.json has been updated Running composer update drupal/commerce_api > Drupal\Composer\Composer::ensureComposerVersion Loading composer repositories with package information Updating dependencies Your requirements could not be resolved to an installable set of packages. Problem 1 To enable extensions, verify that they are enabled in your .ini files: Installation failed, reverting ./composer.json and ./composer.lock to their original content. |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) yeah certain projects require extensions, we cannot test them… this is exposed in the results browser https://dev.acquia.com/drupal10/deprecation_status/projects/commerce_stripe >> read the error log link |
| Gábor Hojtsy (he/him) | I don’t think this will ever be possible to have all the extensions :smile: |
| Björn Brala (bbrala) | The only error is ext-bvmath :confused: |
| Gábor Hojtsy (he/him) | 620 projects have some kind of composer issue https://dev.acquia.com/drupal10/deprecation_status/projects?next_step=--... |
| Björn Brala (bbrala) | Check this: |
| Björn Brala (bbrala) | only one missing in the first half of the results :x |
| Björn Brala (bbrala) | but ok, this is just distracting. |
| Gábor Hojtsy (he/him) | yeah civicrm wants ext-intl for example https://dispatcher.drupalci.org/job/project_analysis_d10/95/artifact/php... |
| Gábor Hojtsy (he/him) | there are probably others like that |
| mglaman | Can't we use ignore platform reqs? |
| mglaman | That ignores ext |
| Björn Brala (bbrala) | what if php req is too low? |
| Gábor Hojtsy (he/him) | we do want it to fail for PHP yeah :smile: |
| Björn Brala (bbrala) | or does drupal ignore that? |
| mglaman | Oh well. No idea then. It's all or nothing unfortunately |
| Björn Brala (bbrala) | --ignore-platform-req=ext-bcmath |
| Björn Brala (bbrala) | but that is a lot of arguments probably :wink: |
| Gábor Hojtsy (he/him) | eg https://dispatcher.drupalci.org/job/project_analysis_d10/95/artifact/php... |
| mglaman | Not too bad if it's automated. And then it's documented. |
| Gábor Hojtsy (he/him) | I think this is a side conversation we can have someday :smile: |
| Björn Brala (bbrala) | hahaha |
| Björn Brala (bbrala) | :stuck_out_tongue: |
| Björn Brala (bbrala) | i'm going to add some minimal testing. |
| Gábor Hojtsy (he/him) | re the machine name offset 2, that would be bad data in the tsv / the way you invoked it? |
| Björn Brala (bbrala) | because finding good rector results in the list is very very hard. |
| Björn Brala (bbrala) | I'll look into it, but first gonna fix the infoupdater tests |
| Björn Brala (bbrala) | been thinking to long on this :wink: |
| Gábor Hojtsy (he/him) | https://dev.acquia.com/drupal10/deprecation_status/projects?next_step=--... is the projects that are fully rectorable, ones the bot should fully fix once it starts running :slightly_smiling_face: almost a thousand projects! |
| Gábor Hojtsy (he/him) | then 3.3k more that will not even run rector and the bot should fix them fully as well just with the info file: https://dev.acquia.com/drupal10/deprecation_status/projects?next_step=--... |
| Björn Brala (bbrala) | lovely (edited) |
| Gábor Hojtsy (he/him) | 4276 projects that the bot will submit a fully done patch for once we run it :open_mouth: (the two above comined) (edited) |
| Gábor Hojtsy (he/him) | then on top of that there are 920 where some of the errors are rectorable so the info file will not be fixed in the patch but some stuff will be fixed :slightly_smiling_face: https://dev.acquia.com/drupal10/deprecation_status/projects?next_step=--... (edited) |
| Gábor Hojtsy (he/him) | so adding all that up, 5196 projects we can hopefully post a meaningful issue for with the bot :rocket: (edited) |
| Gábor Hojtsy (he/him) | @mglaman two rector related updates I made to the bot code isto disable the “useless rector undoer” script, which undid FQDN production in otherwise untouched files and added whitespace — I think this used to be a rector bug that is not a bug anymore(?)to disable the special rector run where if rector produced an empty output and its error output was mentioning tests, it ran it again on code without tests — I don’t know what that was crafted for but I think that is also likely outdated now :crossed_fingers: |
| Björn Brala (bbrala) | I've pushed the updated tests |
| Björn Brala (bbrala) | image.png |
| Björn Brala (bbrala) | only the one left. |
| Björn Brala (bbrala) | hmm push rejected :stuck_out_tongue: |
| Björn Brala (bbrala) | you still pushing hehe |
| Björn Brala (bbrala) | Did you fix the typo then? |
| Gábor Hojtsy (he/him) | Yeah that typo I fixed I think :smile: not pushing anymore |
| Björn Brala (bbrala) | that was a bit annoying lol, rebase was failing on that commit even when trying to use your change over mine. |
| Björn Brala (bbrala) | rebase is magic sometimes :confused: |
| Gábor Hojtsy (he/him) | last push was 43 minutes ago :slightly_smiling_face: avoided the tests entirely since I knew you were on them |
| Gábor Hojtsy (he/him) | need to sign off for the day, hope my changes still work well :smile: |
| Björn Brala (bbrala) | You made an oopsie |
| Björn Brala (bbrala) | ow not you |
| Björn Brala (bbrala) | was already there |
| Björn Brala (bbrala) | public static function findMachineName(string $composer_components) { has one argument not two o_O |
| Björn Brala (bbrala) | ill fix and push, then i'll put the issue in needs review :wink: |
| Björn Brala (bbrala) | takl to you tomorrow again i guess heh |
| Björn Brala (bbrala) | @mixologic you there? It seems you broke something here, and i want to understand why. |
| mglaman | I'm glad you all figured it out. I still can't get vagrant to run on either of my computers |
| Björn Brala (bbrala) | to be honest, im not running the tests on vagrant, just a php 7.4 wsl instance. |
| Björn Brala (bbrala) | i did run the project bot on the machine though, took a little massaging. |
| Björn Brala (bbrala) | although in the end it was mostly just missing a real dns /etc/resolv.conf and me forgetting to turn off hyperv before starting. Works fine after that :slightly_smiling_face: |
| Björn Brala (bbrala) | @mixologic https://git.drupalcode.org/issue/infrastructure-3279548/-/blob/32422e516...…]t_analysis/project_analysis_utils/src/MachineNameFinder.php You removed the argument here from findMachineName but the test kinda espects it (https://git.drupalcode.org/issue/infrastructure-3279548/-/blob/32422e516...…]ect_analysis_utils/tests/src/Unit/MachineNameFinderTest.php). Guess the CSV format changed? |
| Björn Brala (bbrala) | Needs review I guess :wink: #3279548: Drupal 9 to 10 project update bot code still produces Drupal 9 info files, need fixing so it can post again#comment-14531595 ;) |
| Björn Brala (bbrala) | hmm |
| mixologic | looking |
| Björn Brala (bbrala) | thx |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) yeah the tsv format did change, I put in the PHP method comment what is the current format, if the tests need updating :) |
| Gábor Hojtsy (he/him) | And now signing off for good :) |
| mixologic | Yeah, the only thing I see is that there was a test I didnt update. |
| mixologic | which, I didnt even know there were tests buried in there. |
| Björn Brala (bbrala) | hehe super secret tests :stuck_out_tongue: |
| Björn Brala (bbrala) | thanks for looking |
| Björn Brala (bbrala) | /** * @covers ::findMachineName */ public function testFindMachineName() { $csv = 'blazy_ui:subcomponent:"",blazy:primary:"^8 || ^9"'; $this->assertSame("blazy", MachineNameFinder::findMachineName($csv)); } |
| Björn Brala (bbrala) | this should be fine then |
| Björn Brala (bbrala) | Who would merge/review these changes @Gábor Hojtsy (he/him)? |
| Gábor Hojtsy (he/him) | @Björn Brala (bbrala) a review from @tedbow on the bot code changes would be nice, ultimately @mixologic will land it when he is happy with them :slightly_smiling_face: did you try the multi-contrib run since my cleanups yesterday? |
| Björn Brala (bbrala) | No i didn't, i'll start it up at home see what the output is. I'll run run the first half again. |
| Björn Brala (bbrala) | With at home i mean, ill remote desktop and start it up :wink: |
| Björn Brala (bbrala) | @Gábor Hojtsy (he/him) want me to post a zipped version of the results folder here to look at? |
| Björn Brala (bbrala) | (no its not done yet) |
| Gábor Hojtsy (he/him) | If it's done I would love to take a look yeah :) |
| Gábor Hojtsy (he/him) | I would need the projects.tsv as well :) any way we can change the scripts to put that into the artifacts would be amazing btw |
| Björn Brala (bbrala) | That was something that was defined in the steps in the json @hestenet (he/him) posted in the other thread. Its part of the kube definition where the pipeline is defined. |
| Gábor Hojtsy (he/him) | Yeah but then the scripts get it as an argument so they could save it? |
| Björn Brala (bbrala) | The getting of the csv is also part of the pipeline |
| Björn Brala (bbrala) | https://drupal.slack.com/archives/C014CT1CN1M/p1652904038278689?thread_t... |
| Björn Brala (bbrala) | much easier to fix there imo :X |
| Gábor Hojtsy (he/him) | I don’t think we have access to that codebase though :smile: |
| Björn Brala (bbrala) | Yeah but @hestenet (he/him) could arrange that. I feel that adding the artifacts to the phpstan folder is kinda cheating. We could ofcourse just copy the file to the phpstan results, although it would need something unique in its filename to not get overwritting in the artifact merge it think. |
| Björn Brala (bbrala) | (the run is getting close i think its at "image_") (edited) |
| Björn Brala (bbrala) | real 81m28.213suser 503m36.188ssys 93m13.312syay |
| Björn Brala (bbrala) | diff --git a/a11y.info.yml b/a11y.info.yml index 944fa7c..f6d7ce5 100644 --- a/a11y.info.yml +++ b/a11y.info.yml @@ -1,6 +1,5 @@ name: 'A11y' type: module description: 'Provides accessibility enhancements useful for any website' -core: 8.x -core_version_requirement: ^8 || ^9 +core_version_requirement: ^8 || ^9 || ^10 package: 'Accessibility'hehe |
| Björn Brala (bbrala) | There you go @Gábor Hojtsy (he/him) |
| Björn Brala (bbrala) | testbot@drupalci:~/testrunner/phpstan/phpstan-results$ ls -la | grep ".patch" | wc -l1398 |
| Gábor Hojtsy (he/him) | nice! |
| Björn Brala (bbrala) | I also attached this to the issue so the reviewer can actually verify something :wink: |
| Björn Brala (bbrala) | Just for visibility; i've run the project_update locally with some pending changes and it produces working d10 info.yml patches :yay: results for half the projects in the thread :slightly_smiling_face: |
| Gábor Hojtsy (he/him) | Reviewed the results. I think rector is not finding its config, because there are no actual rector fixes in this batch. Only info fixes. However, rector does run because it still produces this whitespace issue that @tedbow used to have a workaround for. Maybe @mglaman can help take a look how to make it find its config that it is not finding? #3279548: Drupal 9 to 10 project update bot code still produces Drupal 9 info files, need fixing so it can post again#comment-14532531 |
| Björn Brala (bbrala) | Aww |
| Björn Brala (bbrala) | At least with the example projects you posted I can do quick runs now. I'll just use a specific set of modules which means it'll run really fast. |
| Gábor Hojtsy (he/him) | I did not cross-check which ones would have fully and partially rectorable things of the patches I added :) just posted to show that the whitespace only changes should not happen |
| Gábor Hojtsy (he/him) | https://dev.acquia.com/drupal10/deprecation_status/projects?next_step=--... are all examples of fully rectorable projects |
| Gábor Hojtsy (he/him) | Similarly you can find examples of partially rectorable projects and info only projects with the next step filters |
| Björn Brala (bbrala) | Kk, would be nice to have a set that has a few different statussen. Easy quick run to test then. |
| Gábor Hojtsy (he/him) | Yeah there are quick lists in the test folder but that is outdated too :) |
| Björn Brala (bbrala) | Hmm, you updates rector in your commits, but the image ws not updated so it didnt run with 12.2 |
| Björn Brala (bbrala) | Guess I need run it in the locally build image. Hopefully it wants to build |
| Björn Brala (bbrala) | Put up a small projects.tsv here: https://bjorn.dev/projects.tsv |
| Björn Brala (bbrala) | new thread since this one is so long: https://drupal.slack.com/archives/C014CT1CN1M/p1653132447057209 |
Comments
Comment #11
gábor hojtsySaving meeting notes. I am sad there is not a way to credit bbrala a 100 ways in this one :)
Comment #12
gábor hojtsyComment #13
bbralaHa! Thx <3