Problem/Motivation

Since the introduction of plugins, DrupalOrgClient needs to be adjusted to use them or be removed/replaced.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3279510

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim.plunkett created an issue. See original summary.

narendraR made their first commit to this issue’s fork.

narendraR opened merge request !74

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Active » Needs review

Hi @fjgarlin, I have updated the code as per review. But in order to make it functional and to not break any existing thing, I duplicated 2 methods in MockDrupalDotOrg, namely getProjectReleasesFromSource & getProjectsFromSource.

fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community

It looks good from my point of view, both code and functionality. Marking as RTBC.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work

There are still unresolved threads on the MR

fjgarlin’s picture

fjgarlin commented

Oh, somehow I missed that. I saw the code changes but not the comments. My bad.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs work » Needs review
fjgarlin’s picture

fjgarlin commented

I've re-checked the code and tested everything. I think that Tim's feedback is well addressed and all functionality is working as expected.
Marking as RTBC but I'll let Tim do the final review in any case.

fjgarlin’s picture

fjgarlin commented
Status: Needs review » Reviewed & tested by the community
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +Project Browser MVP

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.