Figure out a way forward to be compatible with Honeypot to 2.1.0, which caused a BC break

The ServiceNotFoundException from that other issue is unrelated.

What version of Drupal core are you using? What version of Webform? Do you have a full stack trace?

I don't use Webform, so I don't have an easy way to try to reproduce this. It seems that Webform does a lot of things internally when integrating with Honeypot, and I don't know anything about the Webform internals. Searching for this error, it does seem that Webform has seen this problem before, so they may have a better idea of where to look for the source of this problem.

I don't see how the 'honeypot' service would get serialized, and that's the only place that the Honeypot module has a reference to the database connection.

I've added some information to the issue summary and I'm going to move this problem to the Webform queue - maybe someone over there can provide guidance.

Same issue here.
D 9.3.12
P 7.4.29
Maria 10.3.27
Webform 6.1.3

Email is sent, but get that error. Went back to previous honeypot, hard refresh and works fine.

5/11/2022: Ping.
Still getting this error. Any ideas on how to fix it?

LogicException: The database connection is not serializable. This probably means you are serializing an object that has an indirect reference to the database connection. Adjust your code so that is not necessary. Alternatively, look at DependencySerializationTrait as a temporary solution. in Drupal\Core\Database\Connection->__sleep() (line 1993 of core/lib/Drupal/Core/Database/Connection.php).

serialize(Array) (Line: 14)
Drupal\Component\Serialization\PhpSerialize::encode(Array) (Line: 111).....

I don't see how the 'honeypot' service would get serialized, and that's the only place that the Honeypot module has a reference to the database connection.

I haven't thrown this into a lab to 100% confirm however a cursory look at the code indicates this would be the most likely location where the HoneyPot service becomes a part of the form. After that it just requires the form to be serialized for some reason (in my experience forms being serialized is not too uncommon even outside of webform)

        '#element_validate' => [
          [$this, 'validateHoneypot'],
        ],

$this being an initialized honeypot service object. Back in 2.0.x and before this callback is to a global function where there is no class to serialize.

Moving this back to Honeypot project queue as there are two reports that just changing the installed version of Honeypot resolves the issue.

I moved this to the Webform queue so I could get some advice from the Webform people who have seen this before with other integrations (search the queue), and to raise awareness there that Honeypot is now using a service so Webform's integration with Honeypot will eventually have to be updated.

The fix does probably have to come in Honeypot but it seems the quickest way to get a resolution is to have the Webform people weigh in on this.

Hello,

I am trying to reproduce this. What are the precise steps to reproduce? The issue title says "anonymous user" but the description omits that.

We are also experiencing this with webform 6.1.3, honeypot 2.1.0 and Drupal 9.2.18. Rolling honeypot module back to 2.0.1 resolved it.

We were alerted to it when our users reported receiving an alert "File upload in progress. Uploaded file may be lost." when attempting to submit a webform with a required "Document file" field. Clicking "OK" on the alert resulted in a form error on the managed file field. When we looked at our PHP logs, we found the LogicException error.

Perhaps there are two separate issues here, but they both went away when I rolled back the honeypot module.

If I can provide any more info, let me know.

Edit: Adding webform version.

It seems like honeypot 2.1.0 should have been honeypot 3.0.0 because 2.1.0 broke backward compatibility.

Same issue Here.
D9.1.12
honeypot 2.1.0
webform 6.1.3

unknowinly entered as duplicate under honeypot issue

https://www.drupal.org/project/honeypot/issues/3279485

I am still lost as to why this is like a bug for Webform to solve when it is honeypot that broke BC in a minor release.

I am still lost as to why this is like a bug for Webform to solve when it is honeypot that broke BC in a minor release

I believe the maianitner is looking for advice from Webform maintainers on how to allow the service to be serialized by the core Form API.

Honestly I think this issue should be in Honeypot and maybe the maintainer could open a support request issue in webform for advice if they require it.

The initial bug report includes one option using the DependencySerializationTrait to solve the issue.

Linking an issue in Honeypot queue that has one patch attempt already.

@cilefen, this was most certainly NOT a BC breaking change. The Honeypot API was not changed. Some procedural functions were PROPERLY deprecated in the minor point release, which is explicitly allowed. Core does that all the time.

And yet it broke Webform, and Core, according to the related issue. You can follow all the rules and still break BC.

It looks as though the fix will be to honeypot.