imagecache_update_5 (introduced in 5.x-2.2) doesn't return anything, consequently it causes an array merge error on update.

CommentFileSizeAuthor
#3 patch.patch722 byteswebernet
patch.patch881 byteswebernet

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

+1 for this and the patch looks fine.

drewish’s picture

drewish commented

can you just do a return array(); instead?

webernet’s picture

webernet commented
StatusFileSize
new patch.patch722 bytes

Sure...

drewish’s picture

drewish commented
Status: Needs review » Fixed

committed to DRUPAL-5--2... started to commit this to HEAD then realized that dopry never added the function to HEAD. so i copied the patch update in and committed to HEAD.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 5.x-2.x-dev » 6.x-2.x-dev
Status: Fixed » Active

This is still not quite fixed: imagecache_update_5 (HEAD) does not have a return value.

drewish’s picture

drewish commented
Status: Active » Fixed

right you are... i'd though i'd copied/pasted the patched version. committed to HEAD.

carole’s picture

carole commented

I ran into this error updating to imagecache 2.2. Did it cause any problems? Do I need to reinstall anything? If yes, how can I do that from here? I bundled this upgrade with an awful lot of other ones and I don't want to revert to my old database & redo them all. BTW, everything looks like it is working fine.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

No, it doesn't cause any problems, but it's just an unpleasant error that may freak people out.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.