On /en/about-umami, I noticed a link to https://www.drupal.org/docs/8/umami-drupal-8-demonstration-installation-.... When I follow the link, it redirects to https://www.drupal.org/docs/umami-drupal-demonstration-installation-profile.
We should update that link, and others, in order to avoid the confusing redirect.
Search for drupal.org/docs in the Umami profile:
grep -ri drupal.org/docs core/profiles/demo_umami
Currently, I find it in two CSV files (for the English and Spanish "About Umami" pages) and in README.txt.
Load each link in a browser. If it redirects you to a different URL, then update the code.
Make sure to update both the link text and the href attribute.
This issue will update the links on the English and Spanish "About Umami" pages.
None
None
N/A
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !2177
Comments
Comment #2
phjouI start working on this during DrupalCon Portland.
Comment #3
phjouComment #5
phjouComment #6
benjifisher@phjou, thanks for fixing this issue!
I reviewed the changes, and they look right.
I checked the link in the README by looking at the issue fork: https://git.drupalcode.org/issue/drupal-3277309/-/tree/3277309-update-li.... The link there works.
I installed the
demo_umamiprofile locally and visited the English and Spanish versions of the "About Umami" page. The links worked.The first test failed with "Fetch Error". I think that is an infrastructure problem, not a problem with the MR. I queued another test.
Unless the testbot disagrees, this issue is fully RTBC.
Comment #7
benjifisherComment #9
markie commentedassisted with this issue yesterday during the mentored contribution. Thanks for the quick review.
Comment #14
lauriiiCommitted 04c1b7f and pushed to 10.0.x. Cherry-picked to 9.5.x, 9.4.x and 9.3.x because Umami is internal. Thanks!