Problem/Motivation

Pager does not reset if adding a filter after navigating pages.

Steps to reproduce

Load the project browser with no filters. Click "next" about 6 times to get to page six of results. Then, click the "Accessibility" filter on the left. No results are shown. However, if you then click back to "First" from the pager, results show.

Proposed resolution

Fix queries/local state to reset the pager after you update filters.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

Fixes UI issue.

API changes

None.

Data model changes

None.

Release notes snippet

Issue fork project_browser-3277224

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

Devon_4224’s picture

Devon_4224 commented

Working on for DrupalCon 2022. Trying to figure out what's happening, going to reproduce the issue and step through the code.

narendraR made their first commit to this issue’s fork.

narendraR opened merge request !64

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Active » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Makes sense to me. I might have left the call using `page` and instead moved the assignment above, but this is equally clear.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.