Problem/Motivation

I see drush 9, shouldn't this be drush 10 ? or does it matter?
https://git.drupalcode.org/project/colorbox/-/blob/8.x-1.x/composer.json...

Remaining tasks

review

Issue fork colorbox-3275188

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joseph.olstad created an issue. See original summary.

shelane’s picture

shelane
Primary language English
commented

This should allow for Drush 10 and 11. When running a site install command with verbose, it gives this debug message:

[debug] colorbox commands loaded even though its constraint (^9) is incompatible with Drush 11.0.5. Broaden the constraint in modules/contrib/colorbox/composer.json (see 'extra\drush\services' section) to remove this message. [10.01 sec, 100.98 MB]

shelane opened merge request !12

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Active » Needs review

Based on other modules https://git.drupalcode.org/project/config_split/-/blob/2.0.x/composer.js... I think is a better strategy to use a version constraint for each version. "drush.services.yml": "^9 || ^10 || ^11"

paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Title: drush 10 ? composer.json » Update drush versions in composer.json
Version: 8.x-1.x-dev » 2.0.x-dev

  • paulmckibben committed 5464f6d2 on 2.0.x 
    Issue #3275188 by shelane, Eduardo Morales Alberti, joseph.olstad:...
paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.