Problem/Motivation

Currently the module cannot be added to a D10 codebase via composer require, due to some conflicts in composer.json (or maybe just because of composer.lock?)

Additionally, there is at least one deprecated function usage:
system_sort_modules_by_info_name()
(see https://www.drupal.org/node/3225999)

Not sure if there are others

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3274701

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim.plunkett created an issue. See original summary.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented

This issue seems to be related to guzzlehttp/guzzle ^6 in project composer.json. Drupal 10 requires Guzzle 7 https://www.drupal.org/project/drupal/issues/3104353.
Not sure but may be removing this dependency from project composer.json can help. And then we can test flow on both Drupal 9 and 10 or/else updating constraint to ^7 in composer.json file.

narendraR opened merge request !35

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs work

There's another change that needs to be made for D10:
Our drupalci.yml copies and modifies core's commit-code-check.sh script, and has to rewrite where to look for things like PHPCS.

Currently, we're specifically looking for vendor/bin/phpcs and rewriting it too be /var/html/vendor/bin/phpcs
But since we need to do this for PHPStan as well, maybe it's worth just rewriting all of vendor/bin to be /var/html/vendor/bin

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs work » Needs review

Implemented suggested changes.
FilesystemCache used in src/DrupalOrg/DrupalOrgClient.php is also depreciated. What can be done her. Please suggest.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

I honestly don't know why FilesystemCache or any of those 3rd party libraries are needed over \Drupal::httpClient(). But as long as we continue to have "doctrine/cache": "^1.10" in composer.json, we'll be okay for now.
Opened #3274906: Evaluate direct usage of Guzzle, Doctrine, etc in DrupalOrgClient::createGuzzleClient() for a follow-up

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

Just a point of information, I believe we were using a Guzzle Cache middleware at some point, but it was no longer needed with newer versions of Guzzle so was factored out (and may not have been factored out completely), just in case that sheds any light. You may not be talking about _that_ caching layer, though.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.