Problem/Motivation

API to get Category list (https://www.drupal.org/api-d7/taxonomy_term.json?vocabulary=3.json) uses only first page to get the data.

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3274577

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendraR created an issue. See original summary.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Issue tags: +Project Browser Initiative
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

For now I think we should hardcode the list. Here it is, the ID and the label. We can then remove the call to the drupal.org endpoint.

_none	"- None -"
193884	"Accessibility"
53	"Administration"
55	"Commerce/Advertising"
56	"Community"
57	"Content"
13434	"Content Access Control"
88	"Content Construction Kit (CCK)"
58	"Content Display"
13158	"Database Drivers"
186018	"Decoupled"
59	"Developer"
4654	"Drush"
104	"E-commerce"
41442	"Education"
60	"Evaluation/Rating"
61	"Event"
19440	"Examples"
11478	"Features Package"
20224	"Fields"
62	"File Management"
63	"Filters/Editors"
122	"Games and Amusements"
64	"Import/Export"
101	"JavaScript Utilities"
65	"Location"
66	"Mail"
67	"Media"
196950	"Migrate"
7404	"Mobile"
97	"Multilingual"
26738	"Multisite"
16190	"Novelty"
90	"Organic Groups (OG)"
51425	"Other"
68	"Paging"
8818	"Path Management"
123	"Performance and Scalability"
19984	"Project management"
116	"RDF"
11480	"Rules"
105	"Search"
69	"Security"
36748	"SEO"
124	"Site Navigation"
7266	"Spam Prevention"
119	"Statistics"
70	"Syndication"
71	"Taxonomy"
73	"Theme Enhancements"
52	"Third-party Integration"
74	"User Access & Authentication"
76	"User Management"
75	"Utility"
89	"Views"

srishti.bankar made their first commit to this issue’s fork.

srishti.bankar opened merge request !42

srishtiiee’s picture

srishtiiee commented
Status: Active » Needs review
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Needs work

Other than the issue with the indentation, this is good to go. At first I was scared of "hardcode the list" but as it's a fixture and we can later replace with a real fetch later, then I think this is the right solution to move forward.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs work » Reviewed & tested by the community

Tests are passing. I think this is good.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work

Had to rebase first and decided to add a test, will merge if still green.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Fixed

Didn't mean to NW it :D but it came back green, so I merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.