Problem/Motivation

The UI test fails with this error 

Drupal\Tests\project_browser\FunctionalJavascript\ProjectBrowserUiTest::testGrid
Behat\Mink\Exception\ResponseTextException: The text "Loading..." was not found anywhere in the text of the current page.

Since the call to updateMostRecentChanges() is removed from the function getAllProjects(), the project grid loads way faster and the text Loading... doesn't appear on the page.

Steps to reproduce

Proposed resolution

Remove $assert_session->pageTextContains('Loading...'); from the test function.

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork project_browser-3273634

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

srishti.bankar created an issue. See original summary.

srishtiiee’s picture

srishtiiee commented
Title: ProjectBrowserUITest failing. » ProjectBrowserUITest failing

srishti.bankar opened merge request !30

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs work 
Checking tests/src/FunctionalJavascript/ProjectBrowserUiTest.php


FILE: ..._browser/tests/src/FunctionalJavascript/ProjectBrowserUiTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 33 | WARNING | [x] A comma should follow the last multiline array
    |         |     item. Found: 'administer modules'
----------------------------------------------------------------------

We'll have to fix this here as well

srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

Tests are passing now. Marking as RTBC

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: ProjectBrowserUITest failing » ProjectBrowserUITest assertion for UI loading is failing due to speedup in page loading

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Thank you! Merged !30

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.