Problem/Motivation

The "Scale crop 7:3 large" image display mode has the image field label set to "visually hidden", showing "Image" to screen readers before the output of the image field.

Steps to reproduce

  1. Open the Umami homepage
  2. Using a screen reader, read the content of the Umami home banner block

    3. Proposed resolution

    Ensure for all image views that the Image label is hidden and not just visually hidden.

    Remaining tasks

    User interface changes

    API changes

    Data model changes

    Release notes snippet

CommentFileSizeAuthor
#10 interdiff_5-10.txt671 bytesravi.shankar
#10 3273426-10.patch1.33 KBravi.shankar
#5 3273426-5.patch690 bytesravi.shankar
#2 3273426-2.patch684 bytesimmaculatexavier

Comments

bramduvigneau created an issue. See original summary.

immaculatexavier’s picture

immaculatexavier commented
Status: Active » Needs review
StatusFileSize
new 3273426-2.patch684 bytes

Attached patch for Hiding "Image" label for Scale crop 7:3 large image display mode

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

This patch has become outdated, but I agree with the proposed change. Once rerolled I'll move this back to rtbc.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 3273426-5.patch690 bytes

Added reroll of patch #2 on Drupal 9.5.x.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 3273426-5.patch, failed testing. View results

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Reviewed & tested by the community

Setting it back to RTBC as per comment #4 and #6.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work

I think we should also update the "responsive_3x2" view mode.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3273426-10.patch1.33 KB
new interdiff_5-10.txt671 bytes

Updated responsive_3x2 view mode as per comment #9 .

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Title: Hide "Image" label for Scale crop 7:3 large image display mode » Hide "Image" label for Scale crop 7:3 large and Responsive 3x2 image display modes

  • lauriii committed 999067c on 10.1.x 
    Issue #3273426 by ravi.shankar, immaculatexavier, borisson_,...

  • lauriii committed 0dc0576 on 10.0.x 
    Issue #3273426 by ravi.shankar, immaculatexavier, borisson_,...

  • lauriii committed c9132c7 on 9.5.x 
    Issue #3273426 by ravi.shankar, immaculatexavier, borisson_,...

  • lauriii committed 6261dee on 9.4.x 
    Issue #3273426 by ravi.shankar, immaculatexavier, borisson_,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 999067c and pushed to 10.1.x. Also cherry-picked to 10.0.x, 9.5.x, and 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.