Meeting of the Bug Smash Initiative 2022-04-12 [#3272628]

Agenda items

Standing items

Who is here
Any other suggested topics
Wins / Thanks / Blockers
Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
The bug I would most like to see fixed
Update on target items from last meeting
What should be the initiative focus for the next 2 weeks?

Statistics

Agenda

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.

quietone	Hi
Griffyn Heels	:wave: Griff, Au
lendude	Len, NL
Arthur Deryckere (KenowaX)	Hi. :slightly_smiling_face:Arthur, from Belgium.I'm a junior dev. and started working in Drupal about a year ago. Really want to get invested in the project. :smile:
Tinto	Hi everyone! :raising_hand:
Eelke Blok	Eelke, NL
dww	Derek, very late.

0️⃣.5️⃣ Welcome to all the newcomers from Drupal Dev Days. Say hi and introduce yourself in this thread. If you're not new, tell us one thing about yourself that people may not know.

larowlan	hi :wave: one thing people may not know about me is that I talk way too fast
Griffyn Heels	howdy :wave: people wouldn’t know that I am a fantastic bbq operator
lendude	Specially for the people down under, I’m one of the few dutch people that have actually played cricket :cricket_bat_and_ball: (and then got kids and then who has the time)
Arthur Deryckere (KenowaX)	Hey. I'm the new guy. :smile:Little fun fact : What I really like about coding (in general) are Unit Testing and Clean Code. :slightly_smiling_face:
larowlan	Welcome @Arthur Deryckere (KenowaX)
Arthur Deryckere (KenowaX)	@larowlan Thanks. :slightly_smiling_face:What's the X in @Griffyn Heels and your name for ?
larowlan	We work at previousnext.com.au
Tinto	Hi everyone! Attended DrupalDevDays in Ghent last week and spent time in the sprint rooms for the first time. I have been designing, building and theming Drupal sites for about 10 years now and but always thought contributing to Drupal (core) was way out of my league. Turns out many people in the sprint rooms are just as clueless as I am sometimes and are more than willing to help. By the end of the week I actually managed to post a working core patch that passed automated testing! :andy_surprised: (#2852724)Thanks again to @lendude for being an awesome mentor!
Eelke Blok	Hey. I’m Eelke, working for iO in Utrecht. Also attended DDD, although just for a day basically, to deliver my talk “Working in the issue queue”. One thing people may not know: I have a classic Mini in my garage that I don’t drive nearly enough. I actually learned Drupal by building the club site.
dww	Hi, I’m Derek. :wave: You might not know that in addition to being a nerd and musician, I’m also a Breema Bodywork instructor (www.breema.com).

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!

larowlan	I triaged a lot of issues this fortnight, and it felt productive :muscle:
quietone	It is a little thing but I am glad it is closed, #2745855: D8 Patch release update notes are hard to find
lendude	Did a lot of Bug smash triage at DDD and managed to get some people excited and working on it
dww	I feel like there were some good bugs smashed that I was involved in, but I’m on my phone for this and it’s harder for me to search and find the nids. :wink:
larowlan	2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

2️⃣.2️⃣ Thanks - a space for callouts to other contributors who’ve helped you

larowlan	@lendude for the 'send me to a random issue to triage', it always turns up juicy issues
lendude	Thanks to everybody that showed up at the bug smash table at DDD!
Arthur Deryckere (KenowaX)	Big thanks @lendude for taking the time to talk to me at DDD. :slightly_smiling_face:
Tinto	I would also like to thank @lendude for his time and patience in guiding me towards my first core contribution during the DrupalDevDays in Ghent.
Eelke Blok	Thanks to everybody that showed up at the bug smash table at DDD!I guess that includes me, although I did not get to any serious smashing in the brief time I had (did punch the button a few times but did not get to something actionable). Will try and schedule more time in the future.

2️⃣.3️⃣ Blockers - what’s getting in the way of your issues / goals

quietone	Unwinding after doing module removal work.
Tinto	I worked on getting a patch working and it passed automated testing. Not really sure what to do next.#2852724: Machine-name field is not effectively hidden from keyboard and screen reader users.
Tinto	More generally I’d say imposter syndrome is my major blocker. I think the bug smash initiative is a great way to remove the barrier for newcomers.
larowlan	Post it in the channel with a :recycle: :recycle: icon (at the start) to signify you want to swap a review with someone
larowlan	There's lots of people in the same boat looking for a review
larowlan	Hopefully you find a reviewer and they provide feedback
larowlan	Once that is addressed they might mark it RTBC
Tinto	Thanks! Will do.
larowlan	And you do the converse for them, review their issue etc

2️⃣.4️⃣ :loudspeaker: If you helped with the triage since the last meeting then don't forget to post a comment to triage issue on d.o.

larowlan	#3272633: [Meta] Bug Smash Initiative triage fortnight commencing 2022-03-29
Tinto	Moved this from Drupal core to the contrib module issue queue, as the Place blocks module is no longer in core. :yum:#2788603: Selected region is not remembered when adding custom block via "Place Block"
Tinto	Tried to reproduce this bug on a local 9.3 install and documented my findings. Marked this issue as closed (could not reproduce).#3090452: Empty exposed filters always added to query on View with Block display
larowlan	Don't forget to post these comments on the Drupal issue above, so you get a contributor credit

2️⃣.5️⃣ Approve last fortnight's minutes

larowlan	we have two lots to approve
larowlan	#3267290: Meeting of the Bug Smash Initiative 2022-03-15
larowlan	#3269825: Meeting of the Bug Smash Initiative 2022-03-29

3️⃣ Core bug statistics - current state of open bugs

quietone	Today: 2022-04-12 From: 2022-03-29 to 2022-04-12 All bugs Open: 72, including 16 fixed Closed: 106 Age Count 00 24 01 04 02 10 03 11 04 05 05 15 06 12 07 08 08 07 09 06 10 03 12 01 Status Count closed (works as designed) 11 closed (duplicate) 14 closed (won't fix) 4 closed (cannot reproduce) 23 closed (outdated) 23 closed (fixed) 31 Approximately 493 yr reduction in total number of years of all open bugs. Only bugs tagged Bug Smash Initiative Open: 11, including 4 fixed Closed: 71 Age Count 00 04 01 03 02 06 03 07 04 03 05 13 06 12 07 07 08 07 09 05 10 03 12 01 Status Count closed (works as designed) 8 closed (won't fix) 2 closed (cannot reproduce) 18 closed (outdated) 22 closed (fixed) 12 closed (duplicate) 9 Approximately 429 yr reduction in total number of years of all open bugs.
larowlan	awesome, that's a huge fortnight
quietone	Yea, it does feel great!
lendude	Awesome stuff!
lendude	Great to see that spike in the 05-06-07+ range!
larowlan	That's what the button limits to right?
lendude	So just going stat nerd here, but there were 35 non-bugsmash issues closed (33% of all closed bugs), which only accounted for 68 years worth of bugs (14%) . You can tell by the big difference in 00. So we are very much hitting our target bugs, the older generation. Nice
lendude	Actually no, the button only limits it to ‘1 year without a comment’, the daily target adds a 5 year old limit onto that
lendude	They are using different lists at the moment (edited)
lendude	I was thinking maybe moving it to a 2 years without a comment cut off
larowlan	Do the bot comments that bump it to the next minor interfere with that?
larowlan	Whatever it's doing now seems to be spot on
larowlan	Consistently served up good issues this week for me
lendude	No the update timestamp isn’t modified by the minor bumps
lendude	We do have to realise that what are good issues for you might be a bit broader than what are good issues for new contributors :wink:
lendude	But happy to leave it as is, no need to tweak it if it works :slightly_smiling_face:
larowlan	Yeah of course
jibran	Can we add % of reduction as well? e.g. Approximately 493 yr(2%) reduction in total number of years of all open bugs.
quietone	Considering that the total number of years is around 27,000 the percentage will most likely always be under 2%.
dww	Fantastic work, everyone! :tada:
lendude	Warning, more stat analysis: with the current number of open bugs (6933) we would see an increase of ~250 years of debt when waiting a fortnight, so the effective decrease of open bug debt this fortnight will be ~250 years

4️⃣ Lets check back on our targets and set some new ones

larowlan	:checkbox: :dart: normal #3064329: Views filter "Published status or admin user" not working with workbench_moderation (edited)
larowlan	:dart: normal #2822041: drupalimage filters attributes of img tags even when Limit allowed HTML tags and correct faulty HTML filter is turned off
larowlan	:checkbox: :dart: major #2984224: MenuLinkContent's "menu_name" base field is a string field rather than an entity reference field (edited)
larowlan	:dart: critical #3172825: Unable to navigate site without drush cr after deleting a menu link throws "Entity not found through the menu link plugin definition and could not fallback on UUID"
quietone	#3064329: Views filter "Published status or admin user" not working with workbench_moderation - Moved to Support Request and fixed.
quietone	#2984224: MenuLinkContent's "menu_name" base field is a string field rather than an entity reference field - Moved to task
quietone	#3172825: Unable to navigate site without drush cr after deleting a menu link throws "Entity not found through the menu link plugin definition and could not fallback on UUID" - commented that I could not reproduce it. Still needs some testing for comment #6 which is about tests.
larowlan	dropped it down to major
larowlan	comment #6 is how to reproduce it in a test (at least that's my reading)
quietone	Yes, I agree with your reading. I might get back to that tonight.
larowlan	5️⃣ Help me - Is there anything you could use a :hand:

5️⃣ Help me - Is there anything you could use a :hand:

quietone	Someone to do the minutes.
Griffyn Heels	I’ll do them this time @quietone - Thanks for your help!

6️⃣ Who is going to Drupal Con Portland

dww	Not me. I’m open to trying to do some remote participation/ mentoring / etc. But I can’t physically be there.

7️⃣ Who wants to run Bug Smash Bingo Triage in the contribution room(s) @ DrupalCon

tim	I don't want to run it, but questions about it - Is this where a random bug is assigned to you basically?
larowlan	It was brought up by @lendude after he ran it at Drupal Dev Days
larowlan	I'm not sure of the exact format, but I think it was people hitting the button here https://lendude.gitlab.io/bug-smash-initiative/ and triaging the issue
larowlan	@lendude will be able to provide some more context when he's online I'm sure
lendude	Yeah it’s helping people find the button but also explaining the concept of ‘triage’. Most people entering a contrib room are coming in there with the ‘fix’ mindset and we need to move them to a ‘triage first and if you come across something that you feel comfortable trying to fix, only then start thinking about fixing it’
lendude	People spend a lot of time in contribution rooms trying to find things to fix, which would be better spend triaging and then when you have put in the time to understand the issue for triage, move on to doing a fix
lendude	So what I did was: find a table and claim it with a #bugsmash sign or in this case a blackboard Show people the button Walk them through an issue together Be very available for questions Send out shouts in slack that we are running this and ANYBODY can do this (edited)
lendude	@ultimike said he was going I think and might know the right people to talk to, so dragging you into this :slightly_smiling_face:
lendude	@tim so yeah it is about using the button, but not about assigning it to you. A lot of the time you open an issue and go ‘naw that looks too complicated’ and then just close it again and hit the button again until you see something you are comfortable with
lendude	But the problem with the classic contribution room mentored sprint is that people are encouraged to look for something to work on and then they start looking at the issue queuy, but hardly anybody makes it passed the first 4-5 pages, which means 250 bugs get all the eyes and the other 6750 are ignored. Which is a shame, because that is where the stuff is that you can actually impact in just 1 day of contributing
ultimike	Yes, I’ll be at DrupalCon. Let me reach out to some folks I know and see if they know of anyone who might be interested in helping out.