Problem/Motivation

"Plain" colorbox style is using element-invisible class to visually hide elements - corresponding style no longer exists in core.

Steps to reproduce

Use "Plain" colorbox style, see colorbox buttons are not hidden.

Proposed resolution

Replace element-invisible class with visually-hidden as per https://www.drupal.org/project/drupal/issues/1363112

User interface changes

none

API changes

none

Data model changes

none

CommentFileSizeAuthor
#3 plain-colorbox-style-wrong-class-3271947-3.patch715 bytest_d_d

Comments

t_d_d created an issue. See original summary.

t_d_d’s picture

t_d_d commented

I will provide a patch soon.

t_d_d’s picture

t_d_d commented
Status: Active » Needs review
StatusFileSize
new plain-colorbox-style-wrong-class-3271947-3.patch715 bytes

patch provided

renatog’s picture

renatog commented
Assigned: t_d_d » Unassigned
Status: Needs review » Reviewed & tested by the community

It really makes sense. +1 to this

Thank you @t_d_d

paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented

  • paulmckibben committed 33df051 on 8.x-1.x authored by t_d_d 
    Issue #3271947 by t_d_d, RenatoG: plain colorbox style is using wrong...
paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented
Status: Reviewed & tested by the community » Fixed

@t_d_d and @RenatoG, thank you for creating and reviewing this patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.