Olivero's next / prev button icon's don't properly adapt in forced colors mode.

We should use a combo of the forced-colors:active media query and fill: linkText on the SVG to fix this.

Testing steps

  1. You have to be in Windows and turn on a high contrast theme. See https://support.microsoft.com/en-us/windows/turn-high-contrast-mode-on-o...
  2. Create a view that has a pager.
  3. If you change the high contrast theme to a dark theme, note that the arrows do not adapt (and become light).
CommentFileSizeAuthor
#8 chrome.png22.45 KBcindytwilliams
#8 edge-icons-after.png245.43 KBcindytwilliams
#8 edge-icons-before.png56.65 KBcindytwilliams
#3 3271666-9.4.x.patch1.49 KBmherchel
#2 3271666-10.0.x.patch1.24 KBmherchel
Windows_11__1_.png16.6 KBmherchel

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3271666-10.0.x.patch1.24 KB

10.0.x patch

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Active » Needs review
StatusFileSize
new 3271666-9.4.x.patch1.49 KB

9.4.x patch

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Issue summary: View changes

Adding testing steps

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned

Hi mherchel thank you, but I couldn't to revise it because my operational system is Linux, sorry!

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
StatusFileSize
new 3271666-9.4.x-7.patch1.2 KB
new 3271666-10.0.x-7.patch974 bytes

Updating patches now that #3272035: Add "linktext" and "canvastext" to cspell dictionary. is in

cindytwilliams’s picture

cindytwilliams commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new edge-icons-before.png56.65 KB
new edge-icons-after.png245.43 KB
new chrome.png22.45 KB

Code looks good and patches apply cleanly. The next/previous icons display correctly in Microsoft Edge using a high contrast theme, and there are no regressions. Marking RTBC.

Before:
Screenshot Before

After:
Screenshot After

  • lauriii committed aa75324 on 10.0.x 
    Issue #3271666 by mherchel, cindytwilliams: Olivero pager's next/prev...

  • lauriii committed c44d966 on 9.4.x 
    Issue #3271666 by mherchel, cindytwilliams: Olivero pager's next/prev...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed aa75324 and pushed to 10.0.x. Also committed 9.4.x patch to 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.