Non-existent service "entity.manager" [#3270906]

Problem/Motivation

Steps to reproduce

Proposed resolution

Here is the patch. To fix issue: non-existent service "entity.manager". As entity manager service is split into different services. Reference: https://www.drupal.org/node/2549139

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#25	hashtag Screenshot 2023-06-21.png	83.96 KB	arpitk
#24	3270906-24.patch	68.9 KB	tmaiochi
#24	interdiff_22-24.txt	9.19 KB	tmaiochi
#22	resolved-coding-standards-3270906-22.patch	68.39 KB	libbna
#20	interdiff_15-20.txt	68.64 KB	victoria-marina
#20	3270906-20.patch	68.21 KB	victoria-marina
#17	image (4).png	44.37 KB	libbna
#15	fix-coding-standards-issues-3270906-15.patch	4.94 KB	vighneshh
#11	dependency-injection-3270906-11.patch	1.58 KB	ruturaj chaubey
#9	Screenshot from 2022-03-25 12-05-36.png	47.51 KB	vighneshh
#7	3270906-7.patch	1.79 KB	Johnny Santos
#7	3270906-1-7.txt	2.26 KB	Johnny Santos
#2	non-existent-service-entity-manager-3270906-1.patch	1.53 KB	vshlbndr

Issue fork hashtags-3270906

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3270906-non-existent-service changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

22 March 2022 at 02:06

vshlbndr created an issue. See original summary.

Status	File	Size
new	non-existent-service-entity-manager-3270906-1.patch	1.53 KB

Comment #3

guptahemant commented 22 March 2022 at 04:18

Issue summary:

View changes

Comment #4

ruturaj chaubey

He/Him

English

Pune, India

commented 22 March 2022 at 04:34

+++ b/hashtags.install
@@ -28,7 +28,7 @@ function hashtags_uninstall() {
+        $bundles = \Drupal::service('entity_type.bundle.info')->getBundleInfo($entity_type);

+++ b/src/Form/ManagerForm.php
+++ b/src/Form/ManagerForm.php
@@ -48,7 +48,8 @@ class ManagerForm extends FormBase {

Can you use dependency injection instead of using the services via the Drupal global class.

+++ b/src/Form/ManagerForm.php
@@ -48,7 +48,8 @@ class ManagerForm extends FormBase {
+            $bundles = $bundle_info->getBundleInfo($entity_type);

Can you use dependency injection instead of using the services via the Drupal global class.

Comment #5

ruturaj chaubey

He/Him

English

Pune, India

commented 22 March 2022 at 05:36

Status:

Needs review

» Needs work

Comment #6

Johnny Santos commented 23 March 2022 at 19:44

Assigned:

Unassigned

» Johnny Santos

I'm going to work as demanded on comment #4

Comment #7

Johnny Santos commented 24 March 2022 at 21:05

Assigned:	Johnny Santos	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	3270906-1-7.txt	2.26 KB
new	3270906-7.patch	1.79 KB

Just finished what is demanded on one of the files, but I noticed that "hashtags.install" is not possible to make a dependency injection since its a procedural file(it does not contains classes).

Comment #8

vighneshh commented 25 March 2022 at 05:32

Assigned:

Unassigned

» vighneshh

I will review This..

Status	File	Size
new	Screenshot from 2022-03-25 12-05-36.png	47.51 KB

Comment #10

ruturaj chaubey

He/Him

English

Pune, India

commented 25 March 2022 at 07:44

Assigned:

Unassigned

» ruturaj chaubey

Comment #11

ruturaj chaubey

He/Him

English

Pune, India

commented 25 March 2022 at 08:20

Assigned:	ruturaj chaubey	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	dependency-injection-3270906-11.patch	1.58 KB

Added the necessary changes in this patch.

Comment #12

victoria-marina commented 25 March 2022 at 18:20

Assigned:

Unassigned

» victoria-marina

I'll review this.

Comment #13

victoria-marina commented 25 March 2022 at 18:40

Assigned:	victoria-marina	» Unassigned
Status:	Needs review	» Reviewed & tested by the community

The #11 successfully adds the dependency injection into the file. Looks good!

Comment #14

vighneshh commented 29 March 2022 at 02:43

Assigned:	Unassigned	» vighneshh
Status:	Reviewed & tested by the community	» Active

$ phpcs --standard=DrupalPractice /var/www/html/alldemo/web/modules/contrib/hashtags/src/Form/ManagerForm.php

FILE: ...var/www/html/alldemo/web/modules/contrib/hashtags/src/Form/ManagerForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  24 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  51 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  93 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 108 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 117 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 119 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
--------------------------------------------------------------------------------

Still seeing this coding standard issue when run phpcs --standard=DrupalPractice /var/www/html/alldemo/web/modules/contrib/hashtags/src/Form/ManagerForm.php

Comment #15

vighneshh commented 29 March 2022 at 02:46

Assigned:	vighneshh	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	fix-coding-standards-issues-3270906-15.patch	4.94 KB

Adding a patch for the necessary changes in issue mention at #14.

Comment #16

libbna commented 29 March 2022 at 04:55

I will review this.

Comment #17

libbna commented 29 March 2022 at 06:07

Status	File	Size
new	image (4).png	44.37 KB

There are no errors related to Dependency Injection but found these extra errors.

Comment #18

libbna commented 29 March 2022 at 06:07

Status:

Needs review

» Needs work

Comment #19

victoria-marina commented 30 March 2022 at 12:43

Assigned:

Unassigned

» victoria-marina

Working on this.

Status	File	Size
new	3270906-20.patch	68.21 KB
new	interdiff_15-20.txt	68.64 KB

Comment #21

libbna commented 5 April 2022 at 10:55

Assigned:

Unassigned

» libbna

I will review this.

Comment #22

libbna commented 6 April 2022 at 03:16

Assigned:

libbna

» Unassigned

Status	File	Size
new	resolved-coding-standards-3270906-22.patch	68.39 KB

4 files were hidden/shown/deleted

Status	File	Size
hidden	fix-coding-standards-issues-3270906-15.patch	4.94 KB
hidden	image (4).png	44.37 KB
hidden	3270906-20.patch	68.21 KB
hidden	interdiff_15-20.txt	68.64 KB

after applying #20 patch found few issues. I have resolved them and created a patch.

Comment #23

tmaiochi commented 6 April 2022 at 17:41

Assigned:

Unassigned

» tmaiochi

I'll review this!

Comment #24

tmaiochi commented 6 April 2022 at 18:48

Assigned:

tmaiochi

» Unassigned

Status	File	Size
new	interdiff_22-24.txt	9.19 KB
new	3270906-24.patch	68.9 KB

In my review, I came across some errors like:
Notice: Undefined property: Drupal\hashtags\Form\ManagerForm::$entity_typeInfo in Drupal\hashtags\Form\ManagerForm->buildForm()
I realized that the wrong variable was used that's why this error triggered, after changing to the correct variable I still had another error:
Warning: Illegal string offset 'label' in Drupal\hashtags\Form\ManagerForm->buildForm()

So I decided to refactor all the code from the ManagerForm.php file and after refactoring it I tested it again and there were no more previous errors.

Kindly review it!

Comment #25

arpitk commented 21 June 2023 at 21:06

Status:

Needs review

» Needs work

Status	File	Size
new	hashtag Screenshot 2023-06-21.png	83.96 KB

Hi I tried the patch #24 but it didnt apply cleanly.

Thanks!

Comment #26

keshavv commented 2 August 2023 at 05:35

I appreciate all your efforts.

But the issue is regarding Non-existent service "entity.manager"
So please fix the issue only related to that. Otherwise we will go nowhere.

Thank you.

Comment #27

9 August 2023 at 08:13

roshni27 made their first commit to this issue’s fork.

Comment #28

9 August 2023 at 08:43

roshni27 opened merge request !2

Comment #29

roshni27 commented 9 August 2023 at 08:55

Status:

Needs work

» Needs review

I have reviewed patches #7 and #11, and they have been applied cleanly. In both patches, the variable $this->entity_typeInfo is being used, but in the defined variable, the name is protected as $entityTypeInfo.

Even though entity_type.bundle.info is injected into the code, it is still being referenced as
$bundle_info = $this->entity_typeInfo->get('entity_type.bundle.info');
$bundles = $bundle_info->getBundleInfo($entity_type);.
I believe it would be more appropriate to use it as follows:
$bundles = $this->entityTypeBundleInfo->getBundleInfo($entity_type).
I have created a merge request. Please take a moment to review it.