Project Browser does not have a contributor.md file. This file is a good addition because it provides useful links of resources on how to contribute to this project.

This issue is related to the "Update Readme" "https://www.drupal.org/project/project_browser/issues/3268626", created by chrisfromredfin.

We are working on this missing contributor.md file as a group for the discover Drupal project. We are learning markdown and the contribution workflow.

https://docs.google.com/document/d/10SwCg2QwlueBQMU1Xw8eLVqcZX9Z0vOPVPA0...

CommentFileSizeAuthor
#8 3269587-8.patch3.79 KBandregp

Issue fork project_browser-3269587

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

NadiaFaucon created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue tags: -Missing file contributor.md +Documentation

Thanks for creating the issue. Here is a link to the doc that the Discover Drupal graduates started, they are ready for input and review.
https://docs.google.com/document/d/10SwCg2QwlueBQMU1Xw8eLVqcZX9Z0vOPVPA0...

jjcs227’s picture

jjcs227
Primary language Spanish
Location Houston, TX
commented
Issue tags: +Novice

I'm going to tag it as novice as well.

Johnny Santos’s picture

Johnny Santos commented
Assigned: Unassigned » Johnny Santos

Thanks for the tag,
I'm going for it

Johnny Santos’s picture

Johnny Santos commented
Assigned: Johnny Santos » Unassigned

Sorry, I misundestood the purpose of the issue.
For what I can see, this is for a specific pre established group(Discover Drupal graduates).

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue summary: View changes

@Johnny Santos feel free to contribute!

The graduates did the first pass, but the doc is ready for community input.
Thanks!

andregp’s picture

andregp commented

I'll take a look into this :)

andregp’s picture

andregp commented
Status: Active » Needs review
StatusFileSize
new 3269587-8.patch3.79 KB

Here is a patch with the contributor.md file formatted.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi, I revised the path #8.

I'm going to move the issue's status to RTBC because this patch followed all issue summary requisites.

Drupal coding standards also was followed.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Reviewed & tested by the community » Needs work 
  1. +++ b/contributor.md
@@ -0,0 +1,58 @@
+4. (Optional) Choose a patch / issue fork / branch, ¶

    Extra character at the end of line 14.
    And should the comma be there? 

  2. +++ b/contributor.md
@@ -0,0 +1,58 @@
+This module uses Svelte as a "frontend" framework. There are many reasons to choose Svelte, but the primary reason is that it does not require this module (or Drupal Core for that matter) to "ship" a frontend framework. Svelte is only used during the development process. Before "shipping," the Svelte code is compiled into "vanilla" HTML, CSS, and JS. ¶

    Extra character at the end of line 46 

  3. +++ b/contributor.md
@@ -0,0 +1,58 @@
+This avoids many of the security and deprecation issues that have historically arisen from shipping jQuery with Drupal. ¶

    Extra character at the end of line 48

There should also be hard line breaks at 80 characters.

Moving to needs work.

Maybe when this gets re-worked it can be converted into a merge request rather than a patch to follow new issue workflow.

Thanks!

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

Sorry I will to work again.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Issue summary: View changes

No need to apologize, it can be difficult to see trailing spaces.

I use the extension Dreditor in Chrome when I review patches. It adds a review button and then allows you to view the patch in an easy to read format

https://chrome.google.com/webstore/detail/dreditor/dhdpoembhlojpmehepead...

There is a video on how to use it: https://drupalize.me/videos/installing-and-using-dreditor

I hope that helps!

elber opened merge request !167

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi I jus did the changes requested on #11 commentary.

andregp’s picture

andregp commented
Status: Needs review » Needs work

Needs work for the points above.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review
andregp’s picture

andregp commented
Status: Needs review » Reviewed & tested by the community

@Elber the corrections above addressed all my comments, and the indentation seems correct. Moving to RTBC.

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone for their work!

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented

Could we also give contribution credits to the other Discover Drupal alumni who helped with the original file?

  • Devon - Devon_4224
  • Joseph - prodigyjoe

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.