[D9] RSS embed field

There are few place where code is wrong, Have to use dependency injection instead of \Drupal. And instead of t(), need to use $this->t() with use \Drupal\Core\StringTranslation\StringTranslationTrait;
FILE: /rss_embed_field/src/Tests/RssEmbedTest.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
36 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
135 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
136 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
144 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /rss_embed_field/src/Plugin/Field/FieldFormatter/Rss.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
108 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------

FILE: /rss_embed_field/src/RssFeedFetcher.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
130 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------

Hello @jacobbell84

After the codebase investigation, I've found some moments to look at:

1.
file: web/modules/contrib/rss_embed_field/src/Plugin/Field/FieldFormatter/Rss.php
context: method viewElements()
issue: The use Reader::setExtensionManager($this->reader); may throw an issue due to the following log:
Expected type 'Laminas\Feed\Reader\ExtensionManagerInterface'. Found 'Laminas\Feed\Reader\Reader'

2.
file: web/modules/contrib/rss_embed_field/src/Plugin/Field/FieldFormatter/Rss.php
context: method sanitizeInput()
issue: @param string $allowed_tags. The param must not be described as a string because the web/core/lib/Drupal/Component/Utility/Xss.php has this definition public static function filter($string, array $html_tags = NULL), so, array or NULL. I think, if you'll use @param mixed $allowed_tags will be better.

3.
file: web/modules/contrib/rss_embed_field/src/RssFeedFetcher.php
suggestion: I do usually prefer to write an interface for a service. Your is a 100+ lines file and has several methods inside. I may have the potential to grow (in the future), so, It's just a suggestion/idea to provide a proper interface for it.

4.
file: web/modules/contrib/rss_embed_field/src/RssFeedFetcher.php
suggestion: It's better to provide the variable types for the method arguments like an example: public function fetch($source_url) > public function fetch(string $source_url) etc.

5.
file: composer.json
suggestion:

{
  "name": "drupal/rss_embed_field",
  "type": "drupal-module",
  "minimum-stability": "dev"
  "homepage": "https://www.drupal.org/project/rss_embed_field",
  "license": "GPL-2.0-or-later",
  "require": {
    "php": ">=7.1"
  }
}

The rest seems to be pretty ok for me and you did a really good job!

Regards,
Andrei

Nice!

Also, there is a missing LICENTE.txt file (at least GPL - GNU GENERAL PUBLIC LICENSE). See http://www.gnu.org/licenses/old-licenses/gpl-2.0.html

Sorry that didn't mention that before.

Ah...i got an issue on my module on this exact issue. Anyway, this is good to know! Thx for your input. Then, i have no issues. Who else can review it?

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.