Drupal 10 compatibility

I'll review this!

Steps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
(5) Tested again with patch, issue resolved.
The code removed all deprecation for this module and It is compatible with D10!

+core_version_requirement: ^8 || ^9 || ^10

This is incorrect, since the deprecations that are fixed here didn't exist in Drupal 8, like RequestEvent. Since D8 is EOL, this module should be updated to support Drupal 9.2+ (https://www.drupal.org/node/3159012)

Also, since this is a minimally maintained and mostly complete module, it should use a requirement like this: '>=9.2'

I'll do this!

First I want to apologize for creating a new branch, I was not able to access the one that was created because there is already another branch with the same name and I tried to test to see if it worked.

As I mentioned, I couldn't access the branch so I used another branch that was created with the issue, and for some reason it wasn't being used, and I uploaded the changes to it and created a new MR since the other one couldn't access the branch to upload the changes!

The right branch is 3267951-drupal-10-compatibility

Kindly review it!

The image on the IS seems to be misleading, I believe that each issue should have a well defined scope focusing on one fix/task. The missing $defaltTheme attributes does not seem to be related to the D10 compatibility topic. IMO we should be focusing just on replacing the deprecated code.

That being said the MR19 does a good job fixing the deprecated code. Looking through the code it seems correct and when running a drupal-check -d on the module with MR19 code it does not return any error.

www-data@5355a80c11b3:/app$ drupal-check web/modules/contrib/autologout/
 14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [OK] No errors   

I would argue though that the $defaultTheme additions could be left to a follow-up issue, but one of the module maintainers could better determine that.

Also, regarding @japerry comment:

Also, since this is a minimally maintained and mostly complete module, it should use a requirement like this: '>=9.2'

Shouldn't it be '>=9.2' || 10 since we want this module to run on D10 too?

After some discussion with some core maintainers, it should be restricted to 9.2 and 10. I was originally suggesting >=9.2 so the module can support any version of Drupal above a certain level, but there are some downsides to this.. notably that you cannot ever revert the functionality in the future.

So long story short, it should say ^9.2|^10

Hi @japerry,

As per your suggestion, I made changes and also resolved some coding standards. Please review this patch.

Thanks