Problem/Motivation

Getting a solid understanding of the Project Browser module is hard to decipher because there was some code put in there as example/placeholder, but does not function. I propose we remove.

Steps to reproduce

Seen in commit 81dda79 and before.

Proposed resolution

Remove the following files:

  • modules/project_browser_extender/project_browser_extender.info.yml
  • modules/project_browser_extender/project_browser_extender.project_browser.yml
  • src/Plugin/drupal_org.project_browser.yml
  • src/ProjectBrowserEndpointInterface.php

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ✅ Review with the product owner
  • ☐ Release

User interface, API, Data Model changes

None. All this code was non-functional.

Release notes snippet

None needed.

Issue fork project_browser-3267656

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisfromredfin created an issue. See original summary.

chrisfromredfin opened merge request !25

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review

narendraR made their first commit to this issue’s fork.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. All these files are not required for now and can be safely removed.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.