Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Remove rdf from core
Steps to reproduce
Proposed resolution
Check for @todo
Bye bye RDF
Remaining tasks
Patch
Review
Commit
User interface changes
API changes
Data model changes
Release notes snippet
RDF has been removed from core in 10.0.0.
RDF was previously installed as part of the standard install profile, but many sites do not use the functionality it provides. If you are not sure what RDF is, it is likely that you can safely uninstall it.
If you want to keep using the functionality provided by RDF, read the recommendations for RDF.
Issue fork drupal-3267515
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
quietone CreditAttribution: quietone at PreviousNext commentedComment #3
quietone CreditAttribution: quietone at PreviousNext commentedComment #4
quietone CreditAttribution: quietone at PreviousNext commentedComment #5
longwaveWe cannot do this until #3243121: Remove RDF module from the Standard profile is completed.
Comment #6
longwaveThe dependency landed so we can move forward with this.
Comment #7
longwaveActually let's postpone on
#3293813: Move RDF-related tests to RDF module
#3267703: Deprecate RDF module
as both of those will clash with a removal.
Comment #8
longwaveComment #9
longwaveThe test refactoring landed, and we are proceeding with deprecations and removals in parallel for other modules, so there is no reason for this to be postponed.
Comment #11
longwaveFirst pass. There are a bunch of comments that refer to RDFa, and even example code in entity.api.php and theme.api.php, that I'm not sure if we should remove here or not.
There are also two Views plugins that need decoupling from RDF - this might need to be migrated to the module itself, although I'm not sure that this seemingly niche feature is worth keeping:
Comment #13
SpokjeMeh, made a mistake in the filled fixture apparently.
Comment #14
SpokjeComment #15
phenaproximaChecked out the branch and ran
find . -name rdf
,find . -name '*rdf*'
, andfind . -name 'rdf*'
. Nothing.grep -irn rdf core --exclude-dir node_modules --exclude-dir core/assets/vendor
, on the other hand, reveals a few stragglers:core/modules/tracker/tests/fixtures/drupal7.php mentions RDF a bunch, but since that module is also going away (IIRC), doesn't matter.
There are also some places in other modules that integrate with RDF and explicitly mention it, like:
Presumably we'll remove these things in a follow-up (or leave them there)? That probably needs committer input.
Comment #16
SpokjeThanks @phenaproxima
Removed:
Note: The actual missing_path in
core/modules/migrate_drupal_ui/tests/src/Functional/d7/Upgrade7Test.php
should IMHO remain, since removing it will fail the test (we did the same for the color module).Reran
yarn spellcheck:make-drupal-dict
, which got rid ofcore/misc/cspell/dictionary.txt:393:easyrdf
.As pointed out by @longwave in #11 there are still some Views stuff and code examples left.
Waiting on a passing committer for guidance on those. Personally I would like to get rid of them as much of possible.
Comment #17
SpokjeNeeds a rebase and updated fixtures after #3227033: Remove Quick Edit from core landed.
Comment #18
SpokjeWell, that could have gone smoother, but we're back in the green.
Comment #19
phenaproximaWe can remove the RDF integration from \Drupal\node\Plugin\views\row\Rss::render; I fixed it in the contrib module (#3307138: Move core's Views integration into this module). Setting to "needs work" for that, for starters.
Comment #20
SpokjeAlso needs a fixtures update.
Shouldn't #19 be a separate issue and shouldn't the deprecation issue for rdf and this issue be postponed on that as well?
Comment #21
quietone CreditAttribution: quietone at PreviousNext commentedIntegrations are supposed to be removed before the deprecation, yes.
So the problem in #19 should be a child issue of the deprecation issue, #3267703: Deprecate RDF module. I haven't looked at the problem. Is there a reason it must be done here in 10 instead of in 9.5?
Comment #22
SpokjeI love the smell of failing fixture updates in the morning.
.
..
...
O wait, I don't :/
Looking into it.
Comment #23
catchI just got a bit over-excited and committed #3267703: Deprecate RDF module because it was RTBC and nice and simple, I see as usual the complexity is over here.
The main reason we've been moving integrations to modules before deprecating them is to ensure that the module actually still works in contrib after a subtree split. Given #3307138: Move core's Views integration into this module is already in the contrib module that's not an issue, but it leaves 9.5.x in a slightly odd state with Views providing support for a deprecated module.
I've gone ahead and opened #3307230: Backport RDF/views integration changes to 9.5.x and I think we have a couple of choices:
1. Postpone this issue on #3307230: Backport RDF/views integration changes to 9.5.x (which we'd commit to all active branches) so that this issue doesn't have to touch the views integration.
2. Commit this issue to 10.0.x, and commit #3307230: Backport RDF/views integration changes to 9.5.x to 9.5.x independently.
Either way we have two issues to deal with, so... no strong preference but let's try to do the simplest/least confusing route if we can.
Comment #24
SpokjeComment #25
SpokjeRrrrrrrrrrrrrrrrrrrrrrerolled after #3307230: Backport RDF/views integration changes to 9.5.x landed.
Comment #26
SpokjeUnsure what to do about the remaining RDF references:
https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/modules/vie...
#3307283: Reinstate deleted Views RSSField integration
@catch in https://drupal.slack.com/archives/C014CT1CN1M/p1662032414511219?thread_t... and https://drupal.slack.com/archives/C014CT1CN1M/p1662032449939259?thread_t...
https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/modules/lin...
@catch in https://drupal.slack.com/archives/C014CT1CN1M/p1662032187209529?thread_t...
https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/modules/nod...
@catch in https://drupal.slack.com/archives/C014CT1CN1M/p1662032272512639?thread_t...
Comment #27
SpokjeAdded release note snippet
Comment #28
SpokjeAdded draft CR
Comment #29
phenaproximaOK, well, I pulled this branch down again and ran the same checks as I did in #15. This time it came back clean, except for some stuff in the migration fixtures, which I assume is okay.
Sooo...is there anything left to do here? We have a release note, a change record, and RDF seems to be out of the code base.
Nah, I'm calling it. This is RTBC once tests pass.
Comment #30
SpokjeComment #32
catchWe still have #3307283: Reinstate deleted Views RSSField integration open against the contrib module, however that functionality isn't central to RDF at all, which was about adding microdata to web pages rather than RSS feeds, so not letting untested functionality added to Views contrib several years before it was added to core hold this up.
Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!