Problem/Motivation

After updating to paragraphs 8.x-1.13 the modal doesnt open after clicking the add in between button.

Proposed resolution

the reason i found, is that the class has changed
from
to

so my suggested solution is to change
paragraphs_features/js/paragraphs-features.add-in-between.js

let deltaInput = dialog.closest('.paragraphs-add-wrapper').querySelector('.paragraph-type-add-modal-delta');
to
let deltaInput = dialog.closest('.paragraphs-add-wrapper').querySelector('.paragraph-type-add-delta.modal');

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

shagel created an issue. See original summary.

shagel’s picture

StatusFileSize
new672 bytes
steveoriol’s picture

StatusFileSize
new97.25 KB

I still get the error with the patch... :-(
error

[...]

For make it to works, I need to choose 'paragraph-type-add-modal-button' instead of 'paragraph-type-add-modal-delta' and not 'paragraph-type-add-delta.modal'

daveiano’s picture

Also getting this issue. The patch does not solve this for my case.

chr.fritsch’s picture

Status: Active » Needs review

We are having a working PR here: https://github.com/thunder/paragraphs_features/pull/58

We will merge it soon.

@steveoriol I think your problem is also in the paragraphs_ee module. That probably needs some adjustments, too.

chr.fritsch’s picture

  • daniel.bosen authored d36f407 on 8.x-1.x
    Issue #3267136 by steveoriol, shagel, chr.fritsch, volkerk: Uncaught...

chr.fritsch’s picture

Status: Needs review » Fixed
steveoriol’s picture

In my case, I still need to choose 'paragraph-type-add-modal-button' instead of 'paragraph-type-add-delta.modal' in the file 'js/paragraphs-features.add-in-between.js' for make it works ...

chr.fritsch’s picture

As I said before, it's because you are also using paragraphs_ee and they need to change code as well since paragraphs released a new version yesterday.

steveoriol’s picture

OK, thank you.

jeroent’s picture

@steveoriol, I created #3267426: Fix compatibility with Paragraphs 1.13.
Feel free to review the patch.

  • volkerk authored 3c37339 on 2.x
    Issue #3267136 by shagel: Uncaught TypeError: deltaInput is null after...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.