Problem/Motivation

Currently, when using this module with Paragraphs 1.13 and the modal view, you get the following JS-error:

Uncaught TypeError: Cannot set properties of null (setting 'value')
    at Object.Drupal.paragraphs_features.add_in_between.setDelta (paragraphs-features.add-in-between.js:248:22)
    at HTMLButtonElement.<anonymous> (paragraphs_ee.admin.js:161:49)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3267426-5.patch1.85 KBjeroent
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

JeroenT created an issue. See original summary.

stborchert’s picture

Uhm, are you sure, you've branched off of the latest version? There seems to be a lot of unrelated changes ...

jeroent’s picture

@stBorchert, you're right. I was working on 2.0.0 instead of 2.0.1. I updated the MR. This should be the right changes.

The MR makes the modal work again, but not sure if i took the right approach.

jeroent’s picture

Status: Active » Needs review
StatusFileSize
new1.85 KB

The patch if someone wants to use composer-patches.

jeroent’s picture

I fixed all feedback. Thanks for the review, @stBorchert!

stborchert’s picture

Assigned: Unassigned » stborchert

Thanks! I will test this in a project we are currently working on and merge it as soon as possible.

steveoriol’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, I confirm that the patch works !

stborchert’s picture

Status: Reviewed & tested by the community » Fixed

Thanks @JeroenT for your work and thanks @steveoriol for testing.

jeroent’s picture

Thanks for committing @stBorchert ;-)

stborchert’s picture

Thanks for committing

Yeah, that's always the hardest part :D

rgpublic’s picture

Sorry to ask, but could there possibly be a new non-dev release, perhaps? Currently we have excluded dev versions, the 2.0.1 release still seems to have this bug and all our sites have this quite severe problem that people cannot add anything after updating via composer.

stborchert’s picture

rgpublic’s picture

Wooow. That was quick. Huge time-saver. Thanks a lot, @stBorchert. PHP_INT_MAX thumbs up.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.