Problem/Motivation
Currently, when using this module with Paragraphs 1.13 and the modal view, you get the following JS-error:
Uncaught TypeError: Cannot set properties of null (setting 'value')
at Object.Drupal.paragraphs_features.add_in_between.setDelta (paragraphs-features.add-in-between.js:248:22)
at HTMLButtonElement.<anonymous> (paragraphs_ee.admin.js:161:49)
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3267426-5.patch | 1.85 KB | jeroent |
Issue fork paragraphs_ee-3267426
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
stborchertUhm, are you sure, you've branched off of the latest version? There seems to be a lot of unrelated changes ...
Comment #4
jeroent@stBorchert, you're right. I was working on 2.0.0 instead of 2.0.1. I updated the MR. This should be the right changes.
The MR makes the modal work again, but not sure if i took the right approach.
Comment #5
jeroentThe patch if someone wants to use composer-patches.
Comment #6
jeroentI fixed all feedback. Thanks for the review, @stBorchert!
Comment #7
stborchertThanks! I will test this in a project we are currently working on and merge it as soon as possible.
Comment #8
steveoriolThanks, I confirm that the patch works !
Comment #10
stborchertThanks @JeroenT for your work and thanks @steveoriol for testing.
Comment #11
jeroentThanks for committing @stBorchert ;-)
Comment #12
stborchertYeah, that's always the hardest part :D
Comment #13
rgpublicSorry to ask, but could there possibly be a new non-dev release, perhaps? Currently we have excluded dev versions, the 2.0.1 release still seems to have this bug and all our sites have this quite severe problem that people cannot add anything after updating via composer.
Comment #14
stborchert@rgpublic Well, why not :) https://www.drupal.org/project/paragraphs_ee/releases/2.0.2
Comment #15
rgpublicWooow. That was quick. Huge time-saver. Thanks a lot, @stBorchert. PHP_INT_MAX thumbs up.