I've updated to 3.0.1 on a 9.2.x site and it breaks my site with this error message:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "file_url_generator". Did you mean this: "url_generator"? in Drupal\Component\DependencyInjection\Container->get() (line 156 of /web/core/lib/Drupal/Component/DependencyInjection/Container.php).

The file_url_generator service was added in 9.3.x: #2940031: Functions file_create_url() and file_url_transform_relative() are deprecated

I suggest raising the requirements to 9.3.x - if you want to keep supporting older versions, you have to switch back to the now deprecated calls

CommentFileSizeAuthor
#3 marketing.local:history:image-gallery 2022-03-16 13-45-16.png77.96 KBc13l0

Issue fork photoswipe-3266485

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

agoradesign created an issue. See original summary.

chrisck’s picture

chrisck
he/him
Location BC, Canada
commented

I can confirm this issue is present. I had to downgrade to 3.0.0 to keep photoswipe working with Drupal 9.2.x.

c13l0’s picture

c13l0 commented
StatusFileSize
new marketing.local:history:image-gallery 2022-03-16 13-45-16.png77.96 KB

I also confirm that photoswipe is no longer working on sites 9.2.x and below

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Closed (works as designed)

Indeed, 3.0.0 is the last version compatible with Drupal < 9.3 (latest stable).
Please use 3.0.0 for older versions or upgrade core to 9.3 to use > 3.0.1

Anybody opened merge request !25

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Closed (works as designed) » Needs work

Sorry, just saw the core version requirement ^9.3 was missing! Thank you for raising this. Then it's a bug of course!

Going to fix that!

  • Anybody committed 83f4037 on 3.x 
    Issue #3266485 by Anybody, C13L0, agoradesign, chrisck: Since 3.0.1...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Fixed

Going to create a new release. Sorry.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Parent issue: » #3122763: Replaced deprecated method for drush_log and drush_delete_dir()

This is a regression from #3122763: Replaced deprecated method for drush_log and drush_delete_dir().

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Should be fixed now. Use

  • 3.0.x for Drupal < 9.3
  • 3.1.x for ^9.3
agoradesign’s picture

agoradesign commented

why is the commit the version 3.1.1 is tagged on, not visible in the commit log here? https://git.drupalcode.org/project/photoswipe/-/commits/3.x

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@agoradesign: We needed 2 branches:
3.x for ^9.3 (future)
3.0.x for legacy.

Commits were thereby sadly a bit messed up due to the required reverts.

agoradesign’s picture

agoradesign commented

I know, but I'm trying to understand, why this commit here is not showing up in the log any branch? https://git.drupalcode.org/project/photoswipe/-/commit/c9f1fc265dd2a35cf...

Shouldn't that be the last one of 3.x?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.