------ -------------------------------------------------------
Line drush/photoswipe.drush.inc
------ -------------------------------------------------------
70 Call to deprecated function drush_log().
84 Call to deprecated function drush_delete_dir():
Use \Symfony\Component\Filesystem\Filesystem::remove.
85 Call to deprecated function drush_delete_dir():
Use \Symfony\Component\Filesystem\Filesystem::remove.
86 Call to deprecated function drush_log().
100 Call to deprecated function drush_log().
103 Call to deprecated function drush_log().
------ -------------------------------------------------------

CommentFileSizeAuthor
#14 3122763-14.patch1.47 KBsaphemmy
#10 3122763-10.patch747 bytesmrinalini9
#6 interdiff_3-6.txt324 bytesprabha1997
#6 3122763-6.patch1.91 KBprabha1997
#3 3122763-3.patch1.91 KBkuldeep_mehra27

Comments

kuldeep_mehra27 created an issue. See original summary.

kuldeep_mehra27’s picture

kuldeep_mehra27 commented
Assigned: Unassigned » kuldeep_mehra27
Issue summary: View changes
kuldeep_mehra27’s picture

kuldeep_mehra27 commented
Assigned: kuldeep_mehra27 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3122763-3.patch1.91 KB

Status: Needs review » Needs work

The last submitted patch, 3: 3122763-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

prabha1997’s picture

prabha1997 commented
Assigned: Unassigned » prabha1997
prabha1997’s picture

prabha1997 commented
Assigned: prabha1997 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3122763-6.patch1.91 KB
new interdiff_3-6.txt324 bytes

Kindly review patch

Status: Needs review » Needs work

The last submitted patch, 6: 3122763-6.patch, failed testing. View results

prabha1997’s picture

prabha1997 commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-2.x-dev » 3.x-dev
Status: Needs review » Needs work
mrinalini9’s picture

mrinalini9 commented
Status: Needs work » Needs review
StatusFileSize
new 3122763-10.patch747 bytes

Added patch for 3.x, please review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Thanks! At first glance:

$dirname 
//vs.
$dir_name

Furthermore large parts from #6 are missing?

ducktape’s picture

ducktape commented

I looked into porting the drush command from Drush 8 to Drush 10. But all it does, is download the library, and that should be done by Composer.
So I think this one can be closed. The old drush command can stay for Drush 8 support.

saphemmy’s picture

saphemmy commented
Assigned: Unassigned » saphemmy
saphemmy’s picture

saphemmy commented
Assigned: saphemmy » Unassigned
Status: Needs work » Needs review
Issue tags: -VbContribution2020
StatusFileSize
new 3122763-14.patch1.47 KB

Reviewed the issue scope fixed in 3.x-dev but still had some deprecated codes which are fixed within my uploaded patch.

victoria-marina’s picture

victoria-marina commented
Assigned: Unassigned » victoria-marina

I'll review this.

victoria-marina’s picture

victoria-marina commented
Assigned: victoria-marina » Unassigned
Status: Needs review » Reviewed & tested by the community

After the #14, I didn't find any other deprecated code, and everything is working as far I can test. It's a RTBC for me.

  • Anybody committed 575d658 on 3.x 
    Issue #3122763 by prabha1997, kuldeep_mehra27, saphemmy, mrinalini9,...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Thank you all here. Committed to 3.x - please have a try!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.