Curent date only applied to cloned entity, not its translation entity [#3266268]

Problem/Motivation

Current date when cloning an entity is only applied to the cloned entity, not the automatically cloned translation.

Steps to reproduce

Clone a node that has a translation and was created by a different date
Result: The original cloned node has the current date as created date, the cloned translation has the original date as created date.

Both are expected to be set by the current date!

Proposed resolution

Also set the current date on the cloned translation.

Comment	File	Size	Author
#5	3266268-curent-date-only-2.patch	1 KB	n.ghunaim
#2	3266268-curent-date-only.patch	1014 bytes	n.ghunaim

Issue fork entity_clone-3266268

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3266268-curent-date-only changes, plain diff MR !12
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

24 February 2022 at 09:29

n.ghunaim created an issue. See original summary.

Comment #2

n.ghunaim commented 24 February 2022 at 09:32

Status	File	Size
new	3266268-curent-date-only.patch	1014 bytes

Comment #3

n.ghunaim commented 24 February 2022 at 09:32

Assigned:	n.ghunaim	» Unassigned
Status:	Active	» Needs review

Comment #4

24 February 2022 at 09:38

n.ghunaim opened merge request !12

Comment #5

n.ghunaim commented 24 February 2022 at 09:40

Status	File	Size
new	3266268-curent-date-only-2.patch	1 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	3266268-curent-date-only.patch	1014 bytes

Fix the comment message.

Comment #6

sinn commented 4 August 2022 at 10:51

Patch solves the issue - with the patch all translations are created using the current time.

Would be nice to have a test.

And small improvement can be applied to have the same time for all translations

     $current_time = $this->timeService->getRequestTime();
      foreach ($languages as $langcode => $language) {
        $translation = $cloned_entity->getTranslation($langcode);
       $translation->setCreatedTime($current_time);
      }