Problem/Motivation

Quoted from parent issue:

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724

@xjm:

Should be hyphenated (un-assign, de-prioritize, re-render, etc.)

There's an interesting question of where to draw the line for these. Generally in English these prefixes are morphologically productive with a hyphen, and get de-hyphenated when the word is adopted into common usage. "Denormalize", "Unsanitized", "Uninstantiated" etc. are all obviously in common usage in programming. "Unsticky", "Unrevisionable", and the like are Drupal terminology, and I'm surprised that "unpublish" and friends aren't already in the main dictionary.

The parent issue tried to fix all words that should be hyphenated, but the patch for this was getting too big thus making it tricky to review. Also there were some debate about which words should be hyphenated, and which shouldn't. So they argued it would be better to separate the issue into 3 smaller ones (one each for words starting with 're', 'de' and 'un'). (see comment links bellow)

#3138768 #26.2 @xjm talks about the presave word and suggests to divide the issue.
#3138768 #31 @longwave agrees to divide the issue and says it's getting tricky to review.
#3138768 #36 @davidhernandez questions about if some words should be hyphenated.
#3138768 #38 @quietone agrees with @longwave about creating separated issues.

Proposed resolution

Check and decide as a group, with first-language speakers contributing, which of the following words are correct in Drupal and which should be hyphenated, then fix them as needed on the code.

  1. rebuilder
  2. reindexing
  3. resave
  4. resaved
  5. resaving
  6. restripe
  7. restriped
  8. rethrown
  9. reuploading

Remaining tasks

  1. Decide as a group what to do with each word.
  2. Remove and fix the words as defined by the group.
  3. Review.
  4. Commit.

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 fix-hypen-re-3265330-4.patch53.49 KBarunkumark

Issue fork drupal-3265330

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andregp created an issue. See original summary.

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
Issue summary: View changes
Issue tags: +Novice, +Portland2022

Adding Novice tag for first step.

Requires native English speaker.

Task: Look at the list of words above, and provide feedback about which should be hyphenated.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

arunkumark made their first commit to this issue’s fork.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Active » Needs review
StatusFileSize
new fix-hypen-re-3265330-4.patch53.49 KB
rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented
Status: Needs review » Active

Same comment as #3265329-7: Fix missing hyphens for prefixes - Words starting with "de". Task is to discuss which words should be hyphenated, and once there's group agreement, then create a patch.

sharayurajput’s picture

sharayurajput commented

so now can I work on this @rootwork ?

rootwork’s picture

rootwork
he/him
Primary language English
Location 🇺🇸 US-Pacific 🌎 Chinook (Multnomah, Clackamas) & Cowlitz lands 🌹 Portland, OR
commented

@sharayurajput yes! You can definitely work on it. But to underscore again that the work for now is to make the case for which of these words should be hyphenated -- not to write a patch (yet).

cindytwilliams’s picture

cindytwilliams commented
Issue tags: -Portland2022 +Prague2022

Tagging this issue for first time contributors at DrupalCon Prague 2022.

Peter Voumard’s picture

Peter Voumard commented

PLEASE NOTE:
I'm new here and not familiar with Drupal. I am a Tech Writer/Editor 20+ yrs and offered to make some general comments here after contacting Amber Hatz.

Primary thought building on earlier observations from xjm was to suggest terms used in the common vernacular omit a hyphen and Drupal specific terms retain a hpyhen as one way of differentiating them. Alternatively most terms unless ambiguity applies do not strictly require a hyphen per se and as such all terms COULD omit the hyphen with Drupal specific terms being denoted in some way in the global glossary.

These are just suggestions the Drupal Core team may wish to use when deciding how to approach the issue of un, de, and re terms for Drupal Help.

Following HERE I will apply my general knowledge of what may/may not be a Drupal term so please factor that in as I am certainly no expert. just wishing to help where I can. 

  • +++ b/core/lib/Drupal/Component/Annotation/Plugin/Discovery/AnnotatedClassDiscovery.php
@@ -152,7 +152,7 @@ public function getDefinitions() {
-                // Store a NULL object, so the file is not reparsed again.
+                // Store a NULL object, so the file is not re-parsed again.

    Whilst I have seen refs for reparse used in Drupal it is also a common term. On that assumption I suggest removal of hyphen as no ambiguity applies either.
    SUGGESTION: Reparsed 

  • +++ b/core/lib/Drupal/Core/Action/Plugin/Action/SaveAction.php
@@ -71,7 +71,7 @@ public function access($object, AccountInterface $account = NULL, $return_as_obj
-    // entity resave. Without a field change, this would not be possible.
+    // entity re-save. Without a field change, this would not be possible.

    Whilst I have seen refs for resave used in Drupal it is also a common term. On that assumption I suggest removal of hyphen as no ambiguity applies.
    SUGGESTION: Resave

  • +++ b/core/lib/Drupal/Core/Asset/CssOptimizer.php
@@ -108,7 +108,7 @@ protected function processFile($css_asset) {
-   * it is not on the AssetOptimizerInterface, so future refactorings can make
+   * it is not on the AssetOptimizerInterface, so future re-factorings can make

    Whilst I have seen refs for refactoring used in Drupal it is also a common term. On that assumption I suggest removal of hyphen as no ambiguity applies.
    SUGGESTION: Refactorings

  • +++ b/core/lib/Drupal/Core/Asset/CssOptimizer.php
@@ -273,7 +273,7 @@ protected function processCss($contents, $optimize = FALSE) {
-   * it is not on the AssetOptimizerInterface, so future refactorings can make
+   * it is not on the AssetOptimizerInterface, so future re-factorings can make

    Whilst I have seen refs for refactoring used in Drupal it is also a common term. On that assumption I suggest removal of hyphen as no ambiguity applies.
    SUGGESTION: Refactorings 

  • +++ b/core/lib/Drupal/Core/Config/ConfigImporter.php
@@ -812,7 +812,7 @@ protected function processExtension($type, $op, $name) {
-      // Installing a module can cause a kernel boot therefore reinject all the
+      // Installing a module can cause a kernel boot therefore re-inject all the

    COMMENT ON REMAINING ITEMS IN PATCH

    SUGGESTION: ALL remaining terms do not appear to be obviously Drupal specific so suggesting NO hyphen applies.

    NOTE: I’m not a developer but as a Tech Writer have a familiarity with the majority of these IT terms BUT this requires someone familiar with Drupal code/useage IF any of these items DO have a special meaning in Drupal??
    Reinject
    Resave (d) (ing)
    Rethrown
    Rebuilder
    Reclosed
    Recolorable
    Redeclaration
    Redirections
    Reimplement
    Reindex (ing)
    Renormalize
    Reparenting
    Reparsed
    Rethrown
    Re-Indexing *Note this term is used in at least once instance when referring to the “Re-index site” button. Technically I could leave as is but for a wholesale approach would rename the button to Reindex site. Another reference relates to Search Re-index Confirmation Form, again could rename to Reindex here. Yet another reference refers to the Re-index button on the Admin page, rename to Reindex.
    Reclosed
    Resampling
    Rehyrdated *used in a non IT context for Asian cooking. Should this be included in a Glossary?? I can see this appears to be part of a Demo module for Drupal.

    Hope this Helps.

    No point in me reviewing un or de terms as we probably need to decide upon a universal approach for Drupal and non Drupal terms w.rt. hyphens.

    • Version: 9.5.x-dev » 10.1.x-dev

    Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

    Version: 10.1.x-dev » 11.x-dev

    Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

    quietone’s picture

    quietone commented
    Issue tags: +cspell error
    quietone’s picture

    quietone commented
    Issue summary: View changes

    Update word list

    Chandansha made their first commit to this issue’s fork.

    Chandansha opened merge request !8567

    chandansha’s picture

    chandansha commented
    Status: Active » Needs review

    Created patch to MR and fixed remaining words

    smustgrave’s picture

    smustgrave commented
    Status: Needs review » Needs work

    MR appears to have issues

    Version: 11.x-dev » main

    Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

    Read more in the announcement.