[Meta] Fix flagged spelling errors due to missing hyphens for prefixes

Adding a patch.

I will review this patch.

Hi @moheraro,
I have tested this patch. This was applied successfully but I have seen 4 warnings regarding the whitespaces. Kindly have a look. I have attached the screenshot also.

Thanks for that Ramya! Fixing it

Fixed issues highlighted by @ramya.

Patch #9 applied successfully.

Some words can still found in the core like "Rerender" using command "grep -ri".

Updated issue description. Added unsanitized to the list

+++ b/core/assets/vendor/jquery/jquery.js
@@ -1331,7 +1331,7 @@ setDocument = Sizzle.setDocument = function( node ) {
-			// The test attribute must be unknown in Opera but "safe" for WinRT
+      // The test attribute must be un-known in Opera but "safe" for WinRT

@@ -6759,7 +6759,7 @@ function boxModelAdjustment( elem, dimension, box, isBorderBox, styles, computed
-		// If offsetWidth/offsetHeight is unknown, then we can't determine content-box scroll gutter
+    // If offsetWidth/offsetHeight is un-known, then we can't determine content-box scroll gutter

I don't think this is right, "unknown" is a valid word.

Updated 3138768-9.patch

1. I don't think this is right, "unknown" is a valid word.

   Changed it back to unknown

2. Have taken liberty in changing from unindexed to non-indexed as that seemed more appropriate.
3. Changed wording in
   

   --- b/core/modules/node/tests/src/Functional/PageViewTest.php
   +++ b/core/modules/node/tests/src/Functional/PageViewTest.php
   @@ -17,7 +17,7 @@
      protected $defaultTheme = 'stark';
   
      /**
   -   * Tests an anonymous and un-permissioned user attempting to edit the node.
   +   * Tests an anonymous and user without permission attempting to edit the node.
       */

4. Changed from unkeyed to non-keyed
   --- b/core/modules/options/tests/src/Functional/OptionsFieldUITest.php
+++ b/core/modules/options/tests/src/Functional/OptionsFieldUITest.php
@@ -83,7 +83,7 @@
// Flat list of textual values.
$string = "Zero\nOne";
$array = ['0' => 'Zero', '1' => 'One'];
- $this->assertAllowedValuesInput($string, $array, 'Unkeyed lists are accepted.');
+ $this->assertAllowedValuesInput($string, $array, 'Non-keyed lists are accepted.');
5. fixed missed words like reindexing, unsanitized, unrouted, unprefixed, rerender

Thanks @mohrerao, for the updation, but I got one more to fix.

Fix for #16

It looks like "unrouted" is still there.

Updated patch and fixed "unrouted" as mentioned in #18, please review.

I'm reviewing this

I have used command "grep -ri" and found no more issues related with spellings, ready for RTBC.

I have used command "grep -ri" and found no more issues related with spellings, ready for RTBC. Also attached the screenshots.

Thanks everyone for your interest in working on this issue.

The patch for this issue should not change any files in core/assets/vendor, as those are non-Drupal libraries within the codebase.

Now that #2972224: Add .cspell.json to automate spellchecking in Drupal core is in, we can make sure this spelling error never happens again by removing the entry from Drupal's dictionrary, so let's update the patch to remove the words that are being fixed here. Thanks!

1. +++ b/core/lib/Drupal/Core/Render/Renderer.php
   @@ -259,7 +259,7 @@ protected function doRender(&$elements, $is_root_call = FALSE) {
   -    // Try to fetch the prerendered element from cache, replace any placeholders
   +    // Try to fetch the pre-rendered element from cache, replace any placeholders
   

   Make note of situations like this where the hyphen makes the line longer than 80 characters. In those cases, the comments will need to be re-wrapped.

2. +++ b/core/modules/content_moderation/tests/src/Kernel/InitialStateTest.php
   @@ -82,7 +82,7 @@ public function testInitialState() {
   -      'title' => 'Presave node',
   +      'title' => 'Pre-save node',
   

   I'm also not sure this change is correct for Drupal; for example, we have hook_entity_presave() (not hook_entity_pre_save(). I'd omit this from the patch for now.

   I'd also suggest a more structured way of looking at this issue: Take all the words in the core dictionary that start with common prefixes (e.g. "un-", "de-", "re-" etc.), put them in the summary, and then as a group, with first-language speakers contributing, decide which are words in Drupal and which should be hyphenated.

Hi @jungle
Made changes as you suggested please review.

I'd also suggest a more structured way of looking at this issue: Take all the words in the core dictionary that start with common prefixes (e.g. "un-", "de-", "re-" etc.), put them in the summary, and then as a group, with first-language speakers contributing, decide which are words in Drupal and which should be hyphenated.

I'd agree with this. This is getting tricky to review with the number of changes, it might be better to break this up into groups of words and do them separately. In the meantime:

1. +++ b/core/lib/Drupal/Core/Render/Renderer.php
   @@ -343,7 +343,7 @@ protected function doRender(&$elements, $is_root_call = FALSE) {
   -    //       https://www.drupal.org/node/2367555 lands.
   +    //   https://www.drupal.org/node/2367555 lands.
   
   @@ -614,7 +614,7 @@ protected function setCurrentRenderContext(RenderContext $context = NULL) {
   -   * - #cache: to cache the result of the placeholder
   +   * - #cache: to cache the result of the placeholder.
   
   @@ -647,7 +647,6 @@ protected function replacePlaceholders(array &$elements) {
        // @see https://www.drupal.org/node/2712935#comment-11368923
   -
        // First render all placeholders except 'status messages' placeholders.
   

   These reformatting changes are out of scope.

2. +++ b/core/modules/jsonapi/src/JsonApiResource/ResourceIdentifier.php
   @@ -236,7 +236,7 @@ public static function compare(ResourceIdentifier $a, ResourceIdentifier $b) {
   -   * Deduplicates an array of ResourceIdentifier objects.
   +   * Duplicates an array of ResourceIdentifier objects.
   

   Deduplicates and duplicates are not the same.

3. +++ b/core/modules/node/tests/src/Functional/PageViewTest.php
   @@ -17,7 +17,7 @@ class PageViewTest extends NodeTestBase {
   -   * Tests an anonymous and unpermissioned user attempting to edit the node.
   +   * Tests an anonymous and user without permission attempting to edit the node.
   

   This doesn't make sense any more. How about "Tests an anonymous user without permission..."

4. +++ b/core/modules/quickedit/js/editors/formEditor.es6.js
   @@ -132,13 +132,13 @@
   -          // Reset an existing entry for this entity in the PrivateTempStore (if
   -          // any) when loading the field. Logically speaking, this should happen
   -          // in a separate request because this is an entity-level operation, not
   -          // a field-level operation. But that would require an additional
   -          // request, that might not even be necessary: it is only when a user
   -          // loads a first changed field for an entity that this needs to happen:
   -          // precisely now!
   +          // Reset an existing entry for this entity in the PrivateTempStore
   +          // (if any) when loading the field. Logically speaking, this should
   +          // happen in a separate request because this is an entity-level
   +          // operation, not a field-level operation. But that would require an
   +          // additional request, that might not even be necessary: it is only
   +          // when a user loads a first changed field for an entity that this
   +          // needs to happen: precisely now!
   

   This seems to be reformatting only, this is out of scope.

5. +++ b/core/modules/quickedit/js/editors/formEditor.es6.js
   @@ -223,12 +223,12 @@
   -          // Second, set the 'htmlForOtherViewModes' attribute, so that when this
   -          // field is rerendered, the change can be propagated to other instances
   -          // of this field, which may be displayed in different view modes.
   +          // Second, set the 'htmlForOtherViewModes' attribute, so that when
   +          // this instances of this field, which may be displayed in different
   +          // view modes.
   

   Some words are missing here, this no longer makes sense.

6. +++ b/core/modules/search/src/Plugin/SearchIndexingInterface.php
   @@ -57,13 +57,13 @@ public function updateIndex();
   +   * this plugin for re-indexing, this method will be called. If this plugin
   +   * uses the default search index, this method can call markForReindex($type)
   

   If we are changing reindexing to re-indexing, does the method need to be renamed markForReIndex()?

7. +++ b/core/themes/claro/js/vertical-tabs.es6.js
   @@ -10,7 +10,8 @@
   - *    - The original Drupal.verticalTab object is built on the same (unprefixed)
   + *    - The original Drupal.verticalTab object is built on the same
   + *      (un-prefixed)
     *      CSS classes that should be used only for theming the component:
   

   This needs rewrapping.

Hi @longwave
Made changes please review.

It feels like each of these should be evaluated individually?

-   *   The unrouted URL assembler service.
+   *   The un-routed URL assembler service.

Unrouted is a valid word without hyphen.

-   *   An unsanitized database name.
+   *   An un-sanitized database name.

Unsanitized also appears in the dictionary without hyphen.

-      // Installing a module can cause a kernel boot therefore reinject all the
+      // Installing a module can cause a kernel boot therefore re-inject all the

Reinject also appears in Merriam-Webster without hyphen.

Anyone know what the authoritative source is the spellchecked uses or are we proposing to just go with whatever the spell checker says for simplicity?

As we already made great progress here, and splitting this into child issues will lose all works almost --

I don't follow why work would be lost.

I agree with longwave that reviewing this is tricky and thus I think effort should be made to make it simpler for the reviewer. Things like
adding a section to the IS explaining unique situations, like Presave in #26.2 and if un-route or unroute is to be used. And right now I favor separate issues, one each for 're', 'de' and 'un'.

I created three child issues, as suggested, and tried my best to document there the most relevant points from this issue's discussion.

#3265329: Fix missing hyphens for prefixes - Words starting with "de"
#3265330: Fix missing hyphens for prefixes - Words starting with "re"
#3265331: [meta] Fix missing hyphens for prefixes - Words starting with "un"

Adding tag for the cspell spelling error issues.

Since #41 when the child issues were made, this became a meta.