Problem/Motivation

At present, the aria* attributes are allowed but role is not. Role is secure and useful for a11y, so it should be enabled by default.

Steps to reproduce

Create a divider like this:

<div class="divider" role="separator" />

The roll will be escaped.

Proposed resolution

Add role to the list.

CommentFileSizeAuthor
#2 3265161-2_markdown_add-role-attribute.patch414 bytesptmkenny
#5 before-applying-patch.png106.66 KBakshay kashyap

Issue fork markdown-3265161

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ptmkenny created an issue. See original summary.

ptmkenny’s picture

ptmkenny commented
Status: Active » Needs review
StatusFileSize
new 3265161-2_markdown_add-role-attribute.patch414 bytes

joelpittet made their first commit to this issue’s fork.

akshay kashyap’s picture

akshay kashyap commented
Assigned: Unassigned » akshay kashyap
akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new before-applying-patch.png106.66 KB

I tested this without applying the patch, and it is working correctly on my end. Please check and verify. I am attaching screenshots for reference.

I am using Drupal version 10.6.0-dev, and the functionality is working as expected in this version.

akshay kashyap’s picture

akshay kashyap commented
Assigned: akshay kashyap » Unassigned
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Thanks for the manual test @akshay kashyap

joelpittet opened merge request !59

  • joelpittet committed de78ea99 on 3.0.x 
    feat: #3265161 a11y: Add "role" to list of HTML attributes supported out...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.