Problem/Motivation

Steps to reproduce

To reproduce:

1. Config workflow and enable moderation_sidebar module for content type article.
2. Go to the page to a new article node.
3. Enter any required fields, like title
4. Click "Preview" to preview the node

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3264639-7.patch2.38 KBjoelpittet
#7 3264639-7-tests-only.patch1.94 KBjoelpittet
#2 preview-new-node-3264639-2.patch442 bytestannguyenhn
Screen Shot 2022-02-16 at 14.00.42.png620.21 KBtannguyenhn

Comments

tannguyenhn created an issue. See original summary.

tannguyenhn’s picture

tannguyenhn commented
StatusFileSize
new preview-new-node-3264639-2.patch442 bytes
tannguyenhn’s picture

tannguyenhn commented
Status: Active » Needs review
justcaldwell’s picture

justcaldwell
he/him
Primary language English
Location Austin, Texas
commented
Priority: Normal » Major

Confirming this issue and that the patch corrects it. Thank you!

Also setting to Major, as it does "trigger a PHP error through the user interface" when you attempt to preview new, unsaved node.

The website encountered an unexpected error. Please try again later.

Symfony\Component\Routing\Exception\InvalidParameterException: Parameter "entity" for route "moderation_sidebar.sidebar_latest" must match "[^/]++" ("" given) to generate a corresponding URL. in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 203 of core/lib/Drupal/Core/Routing/UrlGenerator.php).
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Confirmed that this works, it also makes sense to not add cacheable dependencies because a new entity has no cache tags.

Tests would be useful.

qusai taha’s picture

qusai taha commented
Status: Needs review » Reviewed & tested by the community

Confirmed this issue and that the patch corrects it

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 3264639-7-tests-only.patch1.94 KB
new 3264639-7.patch2.38 KB

Here's what I hope is a red/green patch for tests. If so, I'll commit this.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thank you @tannguyenhn and all who tested this patch out, I've committed it to the dev branch for a new release.

  • joelpittet committed 20afd75 on 8.x-1.x 
    Issue #3264639 by joelpittet, tannguyenhn, justcaldwell, Berdir, Qusai...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.