Check routing.yml files for deprecated `requirements` access checks in extensions

They shouldn't be extended. So I guess it could be a simply string scan in the routing.yml, like a code sniff.

Mobile review and it looks good.

Part of me wants to add something like this to phpstan-drupal, but there wouldn't be a great time to process. Like if we knew the method was for a controller.

But parsing all of the services.yml (~136 on a basic site) takes a few seconds. Not sure how much more routing would do.

+++ b/src/RouteDeprecationAnalyzer.php
@@ -0,0 +1,65 @@
+    $routing_files = $this->getAllRoutingFiles(DRUPAL_ROOT . '/' . $extension->getPath());
+    foreach ($routing_files as $routing_file) {
+      $content = file_get_contents($routing_file);
+      if (strpos($content, '_access_node_revision')) {
+        $deprecations[] = new DeprecationMessage('The _access_node_revision routing requirement is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use _entity_access instead. See https://www.drupal.org/node/3161210.', $routing_file, 0);
+      }
+      if (strpos($content, '_access_media_revision')) {
+        $deprecations[] = new DeprecationMessage('The _access_media_revision routing requirement is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use _entity_access instead. See https://www.drupal.org/node/3161210.', $routing_file, 0);
+      }
+    }

Should we be taking this approach or using \Drupal\Core\Routing\RouteProviderInterface::getAllRoutes to inspect the compiled routes? What if something is dynamically building routes and attaching these.

This doesn't handle dynamically declared routes. Such as routes provided by entity type route handlers.

Okay, I realized the problem with \Drupal\Core\Routing\RouteProviderInterface::getAllRoutes is that we cannot filter routes down to the one being provided by an extension. It seems like we need to have a global check versus just per module.

One approach would be to use the RouteProvider but filter out routes that do not begin with the module's name. But that assumes everyone is following the pattern of namespacing route names to the module name.

This also wouldn't fix generated entity routes provided by the modules. So I think we need two checks. One per-extension and also a site-wide check on the known routes.

---

I wrote the above while @Gábor Hojtsy posted. Seems like we really need a mix of both.

What I think we need to do:

- Keep the original patch which globs files and inspects them for individual analysis
- Add a site wide routes check to verify all known routes are OK

Opened #3267620: Check all registered routes for deprecated requirements.

This is my trick in tests, for phpstan-drupal:

    [$version] = explode('.', \Drupal::VERSION, 2);
    if ($version !== $major) {
      self::markTestSkipped("Only tested on Drupal $major.x.x");
    }