Problem/Motivation

When the database type is pgsql, the type gets changed to PostgreSQL when checking for pg_trgm. This causes the wrong JSON support check to be run later in that function.

Proposed resolution

Use a different variable to store the full name of the database instead of changing $type.

Issue fork upgrade_status-3263287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

Liam Morland opened merge request !23

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Ah, good find, thanks! I think we should change the $type variable to be more specific though, or otherwise we'll run into this again in another way. Eg. make it $db_type or $database_type or somesuch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: JSON support check does not work on pgsql » JSON support check does not work on pgsql due to database type name being overwritten

  • d975ff5 committed on 8.x-3.x 
    Issue #3263287 by Liam Morland: JSON support check does not work on...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

This looks great, thanks again!

Liam Morland closed merge request !23

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.