Problem/Motivation

A number of return type hints need to be added for Symfony 6 support.

Proposed resolution

Add the return type hints.

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

For the committer: The patch was part of the patch from #3161889-229: [META] Symfony 6 compatibility from @longwave.

CommentFileSizeAuthor
#2 3262190-2.patch17.8 KBdaffie

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie commented
Status: Active » Needs review
StatusFileSize
new 3262190-2.patch17.8 KB

The added return type hints and test fixes.

daffie’s picture

daffie commented
Issue summary: View changes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Thank you @daffie for opening this and extracting the fixes. Double checked this by applying #3161889-230: [META] Symfony 6 compatibility and then reverting this on top, and this covers all the typehints, test fixes, etc I added over there; the only difference is a change of call order in NegotiationMiddlewareTest that doesn't ultimately make a difference.

Once this is committed this should reduce the next Symfony 6 patch to Composer changes only, except for a handful of fixes that we haven't worked out yet.

However, not sure I can RTBC this one as I worked on the original?

daffie’s picture

daffie commented

@longwave: I think you can set the patch to RTBC. The main thing is that 2 people think that the patch is correct. For me the patch is RTBC.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

OK, as we both agree it is RTBC, RTBC it is!

  • catch committed 27158f7 on 10.0.x 
    Issue #3262190 by daffie, longwave: Add miscellaneous return type hints...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yep extracting the patch from the issue doesn't count as authoring, so since longwave is the original author and daffie reviewed and re-rolled, doesn't count as a self-RTBC here.

Patch looks great and agreed with minimising the Symfony 6 changes to the absolute minimum on the main issue.

Committed 27158f7 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.