This task was created for #3253156: [meta] Remove IE11 Support from Olivero

The problem: we are finally able to kick IE11 support from Olivero starting in Drupal 10 (original node)

How to solve this issue: remove CSS related to ie11-autorow classname and remove this classname from all places where it's used within Olivero

Tests: be sure after such removal layouts are still looking correct in other browsers (especially MS Edge, but globally everything should be fine with MS Edge, since according to this table grid's stuff can be written for MS Edge without vendor prefixes)

CommentFileSizeAuthor
#6 autorow-remove-3262135-6.patch282 bytesarunkumark

Issue fork drupal-3262135

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kostyashupenko created an issue. See original summary.

kostyashupenko opened merge request !1767

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Active » Needs review
xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Critical
Issue tags: +Drupal 10 beta blocker
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Patch looks great, only one instance of "autorow" remains:

core/misc/cspell/dictionary.txt
79:autorow

We can remove it from the cspell dictionary now we no longer use this word in core.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Needs work » Needs review
StatusFileSize
new autorow-remove-3262135-6.patch282 bytes

Created patch to work with Fork to remove the autorow from the Olivero.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

#6 needs to be committed to the MR.

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier opened merge request !2437

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

Rebased the branch and force pushed.

Spokje made their first commit to this issue’s fork.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Since I "only" rebased the MR and didn't change any code, I _think_ I'm still eligible to RTBC it.

- TestBot returns green
- Changes make sense
- Clicked around on a test-site created with this branch with MS Edge and didn't notice any regressions. Note: This was _not_ a very extensive test.

Note: (Perhaps) A bit confusing, but the correct MR is MR!1767

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

  • catch committed 15ebeed on 10.0.x 
    Issue #3262135 by kostyashupenko, longwave, Spokje, arunkumark,...
  • catch committed f3b8954 on 10.1.x
    Issue #3262135 by kostyashupenko, longwave, Spokje, arunkumark,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.