Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel’s picture

gauravvvv’s picture

kostyashupenko’s picture

Issue summary: View changes
kostyashupenko’s picture

Issue summary: View changes
kostyashupenko’s picture

Issue summary: View changes
mherchel’s picture

Issue summary: View changes
xjm’s picture

Priority: Normal » Critical
Issue tags: +Drupal 10 beta blocker
xjm’s picture

Issue tags: -Drupal 10 beta blocker

Actually, just tagging potentially required children. Some of them are should–haves.

xjm’s picture

longwave’s picture

wim leers’s picture

Issue summary: View changes

#3306098: Remove .woff font files landed! 👍

Updated issue summary.

longwave’s picture

longwave’s picture

Priority: Critical » Major

I think only #3262156: Olivero: Simplification of the grid layouts to use CSS grid (instead of Flexbox) remains here. Downgrading to major, as there is no problem if we don't complete this, it is only removing some technical debt.

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Is an issue needed for this item in the Issue Summary, "Ability to use negative numbers when specifying grid columns.'?

quietone’s picture

Status: Active » Needs review

In #16 @longwave suggests that this is complete.

I tried to confirm that pinging the Olivero maintainers in #olivero in November but haven't had a response. I tried also in #core-development in December but didn't get a response there either.

So, are we done here?

quietone’s picture

Status: Needs review » Reviewed & tested by the community

Changing status in another attempt to get feedback.

longwave’s picture

Status: Reviewed & tested by the community » Needs work

Still several references in the CSS that can likely be removed in a new child issue:

core/themes/olivero/css/components/header-search-narrow.pcss.css:    background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
core/themes/olivero/css/components/header-search-narrow.pcss.css:      /* IE11's high contrast show will not show the background image, so we show the text. */
core/themes/olivero/css/components/node.css:  background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
core/themes/olivero/css/components/search-results.pcss.css:    background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
core/themes/olivero/css/components/button.pcss.css:    IE11 doesn't work properly on button elements so we only do
core/themes/olivero/css/components/header-search-wide.css:  z-index: 1; /* Ensure left border shows above social region in IE11. */
core/themes/olivero/css/components/header-search-wide.css:  background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
core/themes/olivero/css/components/search-results.css:  background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
core/themes/olivero/css/components/navigation/nav-primary-no-js.pcss.css:       * because it will break IE11 and earlier versions of MS Edge.
core/themes/olivero/css/components/header-search-wide.pcss.css:  z-index: 1; /* Ensure left border shows above social region in IE11. */
core/themes/olivero/css/components/header-search-wide.pcss.css:  background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
core/themes/olivero/css/components/navigation/nav-primary-no-js.css:       * because it will break IE11 and earlier versions of MS Edge.
core/themes/olivero/css/components/navigation/nav-primary-wide.pcss.css:        overflow: visible; /* Necessary to view icon in IE11 */
core/themes/olivero/css/components/header-search-narrow.css:  background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
core/themes/olivero/css/components/header-search-narrow.css:  /* IE11's high contrast show will not show the background image, so we show the text. */
core/themes/olivero/css/components/navigation/nav-primary-wide.css:    overflow: visible; /* Necessary to view icon in IE11 */
core/themes/olivero/css/components/button.css:    IE11 doesn't work properly on button elements so we only do
core/themes/olivero/css/components/node.pcss.css:    background-image: linear-gradient(var(--color--primary-50), var(--color--primary-50)); /* Two values are needed for IE11 support. */
longwave’s picture

longwave’s picture

Status: Needs work » Needs review

#3519513: Remove remaining IE11 support from Olivero landed so I think we are done here - setting to NR for someone to check that I haven't missed anything.

quietone’s picture

Status: Needs review » Fixed

Only found references in Claro as shown below and made a sibling issue for that.

$ grep -ri IE11 --exclude-dir="node_modules" --exclude-dir="assets" core
core/themes/claro/js/tableselect.js:        // is preferable, but not supported by IE11.
core/themes/claro/js/tableselect.js:          // Determine add/remove with ternary since IE11 does not support the

Therefore closing this meta.

Thanks to everyone who kept this meta up to date.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.