In the list of invalid permissions, only the last role with invalid permissions is displayed. This is because each time around the loop, the array is overwritten with the information about the current role.

CommentFileSizeAuthor
#7 Screenshot 2022-02-02 at 21-31-30 Drupal 10 upgrade status Drush Site-Install.png208.54 KBliam morland

Issue fork upgrade_status-3262102

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

Liam Morland opened merge request !21

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Great find! Item lists have a #title I think which would be more appropriate though? https://api.drupal.org/api/drupal/core%21includes%21theme.inc/function/t...

Does that look too bad / heavy?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The #title displays in an h3 element. I don't think the makes sense in this context.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Ok good point. Do you have a situation where you can screenshot how this ends up looking? :) It would be great to see to make sure this looks right.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new Screenshot 2022-02-02 at 21-31-30 Drupal 10 upgrade status Drush Site-Install.png208.54 KB

  • ffc17b3 committed on 8.x-3.x 
    Issue #3262102 by Liam Morland: Only the last role with invalid...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Ok looks great to me both in terms of UI and code. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.