Problem/Motivation

See parent issue for a detailed description.

Proposed resolution

Modify SkipOnValue process plugins to use InvalidArgumentException and to validate configuration in the constructor instead of ::tranform method.

Replace SkipOnValueTest::testRequiredProcessConfiguration and SkipOnValueTest::testRequiredRowConfiguration with generic testRequiredRowConfiguration because we throw error on Plugin contraction, so we don't need to check separate methods.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dinazaur created an issue. See original summary.

dinazaur’s picture

Issue summary: View changes
dinazaur’s picture

Assigned: dinazaur » Unassigned
Status: Active » Needs review

Matroskeen made their first commit to this issue’s fork.

  • Matroskeen committed 4fb94a8 on 8.x-5.x authored by dinazaur
    Issue #3261275 by Matroskeen: Throw consistent exceptions on \Drupal\...
matroskeen’s picture

Status: Needs review » Fixed

Verifying configuration properties in the plugin constructor instead of row/process methods makes sense to me.
Thanks!

matroskeen’s picture

Issue tags: +LutskGCW22

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.