Problem/Motivation

See Drupal core issue for motivation and proposed resolution: #3247950: Throw consistent exceptions on invalid process plugin configurations. Let's support this initiative and apply the same to Migrate Plus process plugins. We can probably be more relaxed and think less about BC changes, but we'll see how it goes.

Proposed resolution

1) Review available process plugins and make sure they throw consistent exceptions;
2) If there is plugin to be fixed, create a child issue;
3) Submit a merge request with proposed changes;

Remaining tasks

Review existing process plugins and create child issues.

Comments

Matroskeen created an issue. See original summary.

matroskeen’s picture

matroskeen’s picture

Status: Active » Postponed

We still have some inconsistency in EntityLookup.php, but this plugin is trying to guess missing properties in ::transform method, so not sure if we can do something about it.

It looks like we also have some usages of InvalidPluginDefinitionException instead of InvalidArgumentException.

Let's wait for #3247950: Throw consistent exceptions on invalid process plugin configurations and then do the rest.