Problem/Motivation

Remove deprecated code from the migration system

d6/Comment
d6/UrlAliasLanguage
d6/ViewMode
field/NodeReferemce
destination/EntityContentBase
ReviewForm.php

Remove migrate_drupal_multilingual module - this module was always intended to have a short life span. It is currently marked experimental and has been hidden since 8.9.x and there was a post update hook to uninstall it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#17 3261004-17.patch6.89 KBpaulocs
#7 3261004-7.patch1.18 MBquietone
#5 3261004-5.patch29.98 KBquietone
#5 interdiff-4-5.txt12.17 KBquietone
#4 3261004-4.patch14.08 KBquietone
#2 3261004-2.patch13.9 KBquietone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
FileSize
3261004-2.patch13.9 KB
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Active » Needs review
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
FileSize
3261004-4.patch14.08 KB
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes
FileSize
interdiff-4-5.txt12.17 KB
3261004-5.patch29.98 KB

Now remove migrate_drupal_multilingual.

Status: Needs review » Needs work

The last submitted patch, 5: 3261004-5.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs work » Needs review
FileSize
3261004-7.patch1.18 MB

This removes migrate_drupal_multilingual from core/modules/system/tests/fixtures/update/drupal-8.8.0.filled.standard.php.gz. There is no interdiff because that was the only change.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes
Related issues: +#2966856: Hide and disable Drupal Migrate Multilingual
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Parent issue: » #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +Deprecation Removal, +Drupal 10
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3261243: Remove deprecated comment module functions, +#3261251: Remove deprecated node module functions

If this one lands first then comment issue should be closed #3261243: Remove deprecated comment module functions

Also there's related to node module clean-up in #3261251: Remove deprecated node module functions

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3261253: Remove deprecated path.module functions

Also path module plugins #3261253: Remove deprecated path.module functions

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#2953111: Only migrate role permissions that exist on the destination
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#3261957: Properly deprecate migrate_drupal_multilingual for future removal

Will need re-roll after #3261957: Properly deprecate migrate_drupal_multilingual for future removal

is it ok to remove 8.8 dump here? it sound like separate issue

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Related issues: +#2966859: Remove Migrate Drupal Multilingual module in Drupal 10
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Assigned: Unassigned » paulocs

Working on it.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented
Assigned: paulocs » Unassigned
FileSize
3261004-17.patch6.89 KB

New patch attached. Kindly review.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Looks ready to go, I can't find any deprecation in all 3 modules

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
CreditAttribution: paulocs at CI&T commented

Should it be moved to RTBC?

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Reviewed & tested by the community

As initial patch made by @quietone (migration sub-system maintainer) I think it's fine to rtbc by myself

  • catch committed f58fccc on 10.0.x 
    Issue #3261004 by quietone, paulocs, andypost: Remove deprecated code...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed f58fccc and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.