Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
There's functions deprecated for removal in core 10
Proposed resolution
remove the usage, make sure no mentions left
Remaining tasks
review/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#8 | interdiff_2-8.txt | 1.63 KB | ravi.shankar |
#8 | 3261251-8.patch | 39.63 KB | ravi.shankar |
|
Issue fork drupal-3261251
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
andypostmostly all cleaned
Comment #3
longwaveAll deprecated code is gone from node.module, only one reference remains:
What is this referring to in PathPluginTest::testPathPlugin()?
Comment #4
andypostThat's where I stuck... probably it needs to change test view to remove usage of deprecated plugin
Otherwise this test fails, so I left this hunk to dig later
Comment #5
daffie CreditAttribution: daffie commentedPatch looks good. Just 1 nitpick:
Update the docblock. The parameter cannot be null.
Comment #6
longwaveAlso we need to update the PHPStan baseline
Comment #8
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedFixed comments number #5 and #6, please review.
Sorry by mistake #7 (issue’s fork) added...
Comment #9
andypostI think it could incorporate changes from #3261245-15: Remove deprecated views module functions maybe event removing
\Drupal\Tests\node\Functional\Views\PathPluginTest
OTOH it smells by new issue - remove remains of node_path pluginComment #10
andypostfix title
Comment #11
daffie CreditAttribution: daffie commentedLooks good to me.
Comment #12
catchCommitted e0cae2b and pushed to 10.0.x. Thanks!
I think it's OK to handle
\Drupal\Tests\node\Functional\Views\PathPluginTest
either in the Views issue, or in a separate spin-off.