Problem/Motivation

There's functions deprecated for removal in core 10

Proposed resolution

remove the usage, make sure no mentions left

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#8 interdiff_2-8.txt1.63 KBravi.shankar
#8 3261251-8.patch39.63 KBravi.shankar
#2 3261251-2.patch38.65 KBandypost

Issue fork drupal-3261251

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3043321: Use generic access API for node and media revision UI, +#3187435: Deprecate $database argument in \Drupal\node\Plugin\views\argument\Vid::__construct(), +#3021804: Remove optional dependency on menu_ui module in \Drupal\views\Plugin\views\wizard\WizardPluginBase, +#3213734: AssertButtonsTrait has invalid PHP syntax, +#2273381: Convert ContextAwarePluginBase to traits, +#3037202: Remove drupal_static() from node_mark()
StatusFileSize
new 3261251-2.patch38.65 KB

mostly all cleaned

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

All deprecated code is gone from node.module, only one reference remains:

    // The configured deprecated node path plugin should be converted to the
    // entity link plugin.
    $field = $view->getHandler('page_1', 'field', 'path');
    $this->assertEquals('entity_link', $field['plugin_id']);

What is this referring to in PathPluginTest::testPathPlugin()?

andypost’s picture

andypost
he/him
Primary language Russian
commented

That's where I stuck... probably it needs to change test view to remove usage of deprecated plugin

Otherwise this test fails, so I left this hunk to dig later

daffie’s picture

daffie commented
Status: Needs review » Needs work

Patch looks good. Just 1 nitpick:

+++ b/core/modules/node/src/NodeAccessControlHandler.php
@@ -66,13 +66,9 @@ class NodeAccessControlHandler extends EntityAccessControlHandler implements Nod
    * @param \Drupal\Core\Entity\EntityTypeManagerInterface|null $entity_type_manager

Update the docblock. The parameter cannot be null.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Also we need to update the PHPStan baseline

		-
			message: "#^The \"access_check\\.node\\.revision\" service is deprecated\\. You should use the 'access_check\\.entity' service instead\\. See https\\://www\\.drupal\\.org/node/3161210$#"
			count: 2
			path: modules/node/tests/src/Functional/NodeRevisionPermissionsTest.php

ravi.shankar made their first commit to this issue’s fork.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3261251-8.patch39.63 KB
new interdiff_2-8.txt1.63 KB

Fixed comments number #5 and #6, please review.

Sorry by mistake #7 (issue’s fork) added...

andypost’s picture

andypost
he/him
Primary language Russian
commented

I think it could incorporate changes from #3261245-15: Remove deprecated views module functions maybe event removing \Drupal\Tests\node\Functional\Views\PathPluginTest OTOH it smells by new issue - remove remains of node_path plugin

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: Remove deprecated node.module functions » Remove deprecated node module functions

fix title

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed e0cae2b and pushed to 10.0.x. Thanks!

I think it's OK to handle \Drupal\Tests\node\Functional\Views\PathPluginTest either in the Views issue, or in a separate spin-off.

  • catch committed 0c65c05 on 10.0.x 
    Issue #3261251 by ravi.shankar, andypost, longwave, daffie: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.