Problem/Motivation

There's functions deprecated for removal in core 10

Proposed resolution

remove the usage, make sure no mentions left

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

Issue fork drupal-3261251

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

longwave’s picture

All deprecated code is gone from node.module, only one reference remains:

    // The configured deprecated node path plugin should be converted to the
    // entity link plugin.
    $field = $view->getHandler('page_1', 'field', 'path');
    $this->assertEquals('entity_link', $field['plugin_id']);

What is this referring to in PathPluginTest::testPathPlugin()?

andypost’s picture

That's where I stuck... probably it needs to change test view to remove usage of deprecated plugin

Otherwise this test fails, so I left this hunk to dig later

daffie’s picture

Status: Needs review » Needs work

Patch looks good. Just 1 nitpick:

+++ b/core/modules/node/src/NodeAccessControlHandler.php
@@ -66,13 +66,9 @@ class NodeAccessControlHandler extends EntityAccessControlHandler implements Nod
    * @param \Drupal\Core\Entity\EntityTypeManagerInterface|null $entity_type_manager

Update the docblock. The parameter cannot be null.

longwave’s picture

Also we need to update the PHPStan baseline

		-
			message: "#^The \"access_check\\.node\\.revision\" service is deprecated\\. You should use the 'access_check\\.entity' service instead\\. See https\\://www\\.drupal\\.org/node/3161210$#"
			count: 2
			path: modules/node/tests/src/Functional/NodeRevisionPermissionsTest.php

ravi.shankar made their first commit to this issue’s fork.

ravi.shankar’s picture

Status: Needs work » Needs review
FileSize
39.63 KB
1.63 KB

Fixed comments number #5 and #6, please review.

Sorry by mistake #7 (issue’s fork) added...

andypost’s picture

I think it could incorporate changes from #3261245-15: Remove deprecated views module functions maybe event removing \Drupal\Tests\node\Functional\Views\PathPluginTest OTOH it smells by new issue - remove remains of node_path plugin

andypost’s picture

Title: Remove deprecated node.module functions » Remove deprecated node module functions

fix title

daffie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed e0cae2b and pushed to 10.0.x. Thanks!

I think it's OK to handle \Drupal\Tests\node\Functional\Views\PathPluginTest either in the Views issue, or in a separate spin-off.

  • catch committed 0c65c05 on 10.0.x
    Issue #3261251 by ravi.shankar, andypost, longwave, daffie: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.