Problem/Motivation

There's functions deprecated for removal in core 10

Proposed resolution

remove the usage, make sure no mentions left

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#2 3261243-2.patch4.95 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost’s picture

longwave’s picture

Status: Needs review » Reviewed & tested by the community

No deprecated methods remain in comment.module, so this is good to go.

One thing I did spot that is marked legacy but that (as far as I know) we have no issue to remove is the comment.node_redirect route, which is the old /comment/{node}/reply path for nodes only which predates multiple comment fields. Should we discuss removing this or shall we just leave it to handle old URLs forever?

andypost’s picture

Good point, needs separate issue to deprecate and remove the route

  • catch committed a1a9297 on 10.0.x
    Issue #3261243 by andypost, longwave: Remove deprecated comment module...
catch’s picture

Title: Remove deprecated comment.module functions » Remove deprecated comment module functions
Status: Reviewed & tested by the community » Fixed

Committed a1a9297 and pushed to 10.0.x. Thanks!

Let's open a follow-up to discuss the route deprecation.

andypost’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.