I have a "feature request" I'd like to suggest. I recognize that it's minor, in the grand scheme of things, but as the old saying goes, "a closed mouth doesn't get fed."
I have noticed for a long while, (probably as long as I've been working with Drupal, so back to D7 somewhere) in the /ADMIN/STRUCTURE/BLOCK/DEMO/[THEMENAME] screen, the "Exit Block Region Demonstration" button is ALWAYS sitting right over at least one of the region tags, making it unreadable. Yes, sure, you can look at the available regions, and based on what you CAN see, you can usually figure out what it is, but I was wondering if it would be possible to move that "Exit Block Region Demonstration" button somewhere else? Ideally, perhaps onto one of the Admin Toolbars? Or maybe make it a Modal, where it can be moved to an out-of-the-way place, with enough of a border to be dragged around without unintentionally hitting the button and closing the screen?
Steps to reproduce
- Go to the "Block layout" (admin/structure/block) page.
- Click on Demonstrate block regions (Theme Name) .
- Exit Block Region Demonstration" button is showing on left side on top .

| Comment | File | Size | Author |
|---|---|---|---|
| #36 | before--patch.png | 90.77 KB | athyamvidyasagar |
| #36 | after--patch.png | 88.67 KB | athyamvidyasagar |
| #36 | 3260884_35.patch | 1.3 KB | athyamvidyasagar |
| #32 | Screenshot-beforepatch-3260884-32.png | 759.71 KB | nikhil_110 |
| #29 | afterpatch.jpg | 116.4 KB | gaurav-mathur |
Issue fork drupal-3260884
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3260884-model-2
changes, plain diff MR !1771
- 3260884-move-the-exit
changes, plain diff MR !1729
Comments
Comment #2
longwaveRetitled to make it clear from the issue listing what "this" means :)
Comment #5
ressaThanks for raising the issue and possible suggestions @BEGRAFX, it's those small things which all add up :)
Perhaps a pragmatic solution would be to make the background transparent? I have created a Merge Request with an example of this.
Comment #6
ressaNow
With transparent background
Comment #7
begrafx commentedThe thing I see with making the background "transparent" is the potential for the two levels of text to make both layers hard to read. Note in my original example image, the "Exit" text and the region name are aligned. Transparency, as you suggest would be a problem. In this same vein, I'm not sure if this is Drupal
, or the theme(s), but I've noticed several recently, that are white region names on the yellow background. Very hard to read.
Comment #8
ressaYou're right, text on text is a challenge ... Sliding it to the right might alleviate most clashes? And I did note the white text on yellow background in your image. That's really hard to read. Is it a contrib theme, that I can see?
Comment #9
tomy mohan commentedcheck these
Model 1
We can simply change the position so it will not hide any text.
when admin toolbar is collapsed:
OR
Model 2
when admin toolbar is collapsed:
I prefer the Model 2 . Please add your comments.
Comment #10
ressaModel 2 is probably best, moving the block regions down a nudge, since there is always a chance of clashing text with the current overlay model.
Comment #11
ressaSince the changes were so minor, I updated the existing MR.
Comment #12
ressaHere is a proof of concept, where the button is not an overlay. More structural changes are probably needed to render it nicer, as seen in your "Model 2" example, @TOMY MOHAN.
Comment #13
begrafx commentedIn my opinion, either of @TOMY MOHAN's suggestions would work. I agree, I think I like model 2 better.
Comment #14
tomy mohan commentedHere is the patch for Model 2.
Comment #15
ressaThanks @TOMY MOHAN, perhaps you can use the Gitlab integration, so we can easily preview it via Tugboat?
I have created a new branch called "3260884-model-2" above for this. Let me know if you would like me to transfer your patch.
Comment #16
gauravvvv commentedFixed custom command failed, Attached interdiff for same. Please review.
Comment #18
ressaThanks @Gauravmahlawat. I re-rolled the patch with the Gitlab integration in the branch "3260884-model-2" (see at the top), so we can easily preview it via Tugboat, maybe we can use that from now on?
It looks fine in Seven, acceptable in Olivero, but not so great in Bartik:
Seven
Olivero
Bartik
I'll try to tweak the padding in the Merge Request.
Comment #19
ressaWith 15px space at top and bottom:
Bartik
Olivero
Seven
Comment #21
ressaBartik looks better now:
Comment #22
tomy mohan commentedMoved the Exit button into the centre of the page.
Comment #23
tomy mohan commentedComment #24
begrafx commentedAnother "variation on this theme" I'd hope we can address is, in this same screen, so often it seems that regions are labeled with a Yellow box/stripe, and WHITE TEXT, which makes it impossible to read.
Comment #25
ressaI think that's probably best addressed in a separate issue ... also, it would be a great help if you include a link to a theme where this happens.
Comment #26
devashish jangid commentedVerified and tested patch #23.
Comment #28
gaurav-mathur commentedComment #29
gaurav-mathur commentedApplied patch in #24. The patch move Exit block region button on top left corner and it work fine.
Comment #31
smustgrave commentedThis issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.
Could someone add screenshots to the issue summary please as this is a UX change.
Comment #32
nikhil_110 commentedComment #33
nikhil_110 commentedComment #34
smustgrave commentedAdding screenshots of how it currently is doesn't provide much help. Before/after is what is needed
Now tagging for issue summary update as it may not be clear what is being addressed.
Comment #35
athyamvidyasagar commentedApplied patch. The patch move Exit block region button on top left corner and it work fine with proper space.
Comment #36
athyamvidyasagar commented