I have a "feature request" I'd like to suggest. I recognize that it's minor, in the grand scheme of things, but as the old saying goes, "a closed mouth doesn't get fed."

I have noticed for a long while, (probably as long as I've been working with Drupal, so back to D7 somewhere) in the /ADMIN/STRUCTURE/BLOCK/DEMO/[THEMENAME] screen, the "Exit Block Region Demonstration" button is ALWAYS sitting right over at least one of the region tags, making it unreadable. Yes, sure, you can look at the available regions, and based on what you CAN see, you can usually figure out what it is, but I was wondering if it would be possible to move that "Exit Block Region Demonstration" button somewhere else? Ideally, perhaps onto one of the Admin Toolbars? Or maybe make it a Modal, where it can be moved to an out-of-the-way place, with enough of a border to be dragged around without unintentionally hitting the button and closing the screen?

Steps to reproduce

  • Go to the "Block layout" (admin/structure/block) page.
  • Click on Demonstrate block regions (Theme Name) .
  • Exit Block Region Demonstration" button is showing on left side on top .

link-text-screenshot

CommentFileSizeAuthor
#36 before--patch.png90.77 KBathyamvidyasagar
#36 after--patch.png88.67 KBathyamvidyasagar
#36 3260884_35.patch1.3 KBathyamvidyasagar
#32 Screenshot-beforepatch-3260884-32.png759.71 KBnikhil_110
#29 afterpatch.jpg116.4 KBgaurav-mathur
#29 beforepatch.jpg121.01 KBgaurav-mathur
#26 3260884-after-patch.PNG19.52 KBdevashish jangid
#26 3260884-after-scroll.png18.7 KBdevashish jangid
#24 TitleHighlights.png18.12 KBbegrafx
#23 exit_button_center-3260884-23.patch762 bytestomy mohan
#22 exit_button_center-3260884-22.patch764 bytestomy mohan
#22 exit_button_seven.png14.36 KBtomy mohan
#22 exit_button_bootstrap.png26.59 KBtomy mohan
#22 exit_button_bartik.png22.76 KBtomy mohan
#21 Bartik-better-border.png35.84 KBressa
#19 Exit-button-15px-15px-Seven.png18.59 KBressa
#19 Exit-button-15px-15px-Olivero.png17.51 KBressa
#19 Exit-button-15px-15px-Bartike.png17.21 KBressa
#18 Exit-button-Bartik.png44.01 KBressa
#18 Exit-button-Olivero.png42.9 KBressa
#18 Exit-button-Seven.png45.6 KBressa
#16 interdiff-3260884-14_16.txt424 bytesgauravvvv
#16 3260884-16.patch1.39 KBgauravvvv
#14 exit_block_region_demonstration_issue_fix-3260884-14393008.patch1.4 KBtomy mohan
#9 admin_collapsed1.png22.84 KBtomy mohan
#9 admin-collapsed-2.png25.17 KBtomy mohan
#9 28-01-2011_button_position_change.png36.56 KBtomy mohan
#9 28_01_2011_model2.png37.82 KBtomy mohan
#6 1.2 Transparent Exit block region demo.png42.05 KBressa
#6 1.1 Current Exit block region demo.png41.02 KBressa
Issue-Example.png49.81 KBbegrafx

Issue fork drupal-3260884

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

BEGRAFX created an issue. See original summary.

longwave’s picture

Title: Can we move this? » Move the "Exit block region demonstration" button

Retitled to make it clear from the issue listing what "this" means :)

ressa made their first commit to this issue’s fork.

ressa’s picture

Status: Active » Needs review

Thanks for raising the issue and possible suggestions @BEGRAFX, it's those small things which all add up :)

Perhaps a pragmatic solution would be to make the background transparent? I have created a Merge Request with an example of this.

ressa’s picture

Now

Now

With transparent background

Transparent background

begrafx’s picture

The thing I see with making the background "transparent" is the potential for the two levels of text to make both layers hard to read. Note in my original example image, the "Exit" text and the region name are aligned. Transparency, as you suggest would be a problem. In this same vein, I'm not sure if this is Drupal
, or the theme(s), but I've noticed several recently, that are white region names on the yellow background. Very hard to read.

ressa’s picture

You're right, text on text is a challenge ... Sliding it to the right might alleviate most clashes? And I did note the white text on yellow background in your image. That's really hard to read. Is it a contrib theme, that I can see?

tomy mohan’s picture

StatusFileSize
new37.82 KB
new36.56 KB
new25.17 KB
new22.84 KB

check these

Model 1

We can simply change the position so it will not hide any text.

Button position change
when admin toolbar is collapsed:
Button position change

OR

Model 2

Button position change
when admin toolbar is collapsed:
Button position change

I prefer the Model 2 . Please add your comments.

ressa’s picture

Model 2 is probably best, moving the block regions down a nudge, since there is always a chance of clashing text with the current overlay model.

ressa’s picture

Since the changes were so minor, I updated the existing MR.

ressa’s picture

Here is a proof of concept, where the button is not an overlay. More structural changes are probably needed to render it nicer, as seen in your "Model 2" example, @TOMY MOHAN.

begrafx’s picture

In my opinion, either of @TOMY MOHAN's suggestions would work. I agree, I think I like model 2 better.

tomy mohan’s picture

StatusFileSize
new1.4 KB

Here is the patch for Model 2.

ressa’s picture

Thanks @TOMY MOHAN, perhaps you can use the Gitlab integration, so we can easily preview it via Tugboat?

I have created a new branch called "3260884-model-2" above for this. Let me know if you would like me to transfer your patch.

gauravvvv’s picture

StatusFileSize
new1.39 KB
new424 bytes

Fixed custom command failed, Attached interdiff for same. Please review.

ressa’s picture

StatusFileSize
new45.6 KB
new42.9 KB
new44.01 KB

Thanks @Gauravmahlawat. I re-rolled the patch with the Gitlab integration in the branch "3260884-model-2" (see at the top), so we can easily preview it via Tugboat, maybe we can use that from now on?

It looks fine in Seven, acceptable in Olivero, but not so great in Bartik:

Seven

Exit button Seven

Olivero

Exit button Olivero

Bartik

Exit button Bartik

I'll try to tweak the padding in the Merge Request.

ressa’s picture

Priority: Minor » Normal
StatusFileSize
new17.21 KB
new17.51 KB
new18.59 KB

With 15px space at top and bottom:

Bartik

Bartik 15px

Olivero

Olivero 15px

Seven

Seven 15px

ressa’s picture

StatusFileSize
new35.84 KB

Bartik looks better now:

Bartik better border

tomy mohan’s picture

StatusFileSize
new22.76 KB
new26.59 KB
new14.36 KB
new764 bytes

Moved the Exit button into the centre of the page.

tomy mohan’s picture

StatusFileSize
new762 bytes
begrafx’s picture

StatusFileSize
new18.12 KB

Another "variation on this theme" I'd hope we can address is, in this same screen, so often it seems that regions are labeled with a Yellow box/stripe, and WHITE TEXT, which makes it impossible to read.

ressa’s picture

I think that's probably best addressed in a separate issue ... also, it would be a great help if you include a link to a theme where this happens.

devashish jangid’s picture

StatusFileSize
new18.7 KB
new19.52 KB

Verified and tested patch #23.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

gaurav-mathur’s picture

Assigned: Unassigned » gaurav-mathur
gaurav-mathur’s picture

Assigned: gaurav-mathur » Unassigned
StatusFileSize
new121.01 KB
new116.4 KB

Applied patch in #24. The patch move Exit block region button on top left corner and it work fine.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs screenshots

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Could someone add screenshots to the issue summary please as this is a UX change.

nikhil_110’s picture

Issue summary: View changes
StatusFileSize
new759.71 KB
nikhil_110’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Adding screenshots of how it currently is doesn't provide much help. Before/after is what is needed

Now tagging for issue summary update as it may not be clear what is being addressed.

athyamvidyasagar’s picture

Applied patch. The patch move Exit block region button on top left corner and it work fine with proper space.

athyamvidyasagar’s picture

StatusFileSize
new1.3 KB
new88.67 KB
new90.77 KB

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.