Problem/Motivation

The patch in #3227033-52: Remove Quick Edit from core where we deprecated Core module quickedit showed that having a deprecated Core module with dependency on non-deprecated modules lead to a test failure in Drupal\Tests\system\Functional\Module\InstallUninstallTest .

Steps to reproduce

- Make a core module deprecated by adding to appropriated lifecyle parameters in its .info.yml file.
- Weep whilst looking at the test failure:

There was 1 error:

1) Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall
Behat\Mink\Exception\ResponseTextException: The text "Some required modules must be enabled" was not found anywhere in the text of the current page.

/var/www/html/vendor/behat/mink/src/WebAssert.php:785
/var/www/html/vendor/behat/mink/src/WebAssert.php:262
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:898
/var/www/html/core/modules/system/tests/src/Functional/Module/InstallUninstallTest.php:129
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

Remaining tasks

Create MR
Review
Commit

Issue fork drupal-3259850

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Status: Active » Needs review
spokje’s picture

Assigned: spokje » Unassigned
daffie’s picture

Status: Needs review » Reviewed & tested by the community

All the code changes look good to me.
The test has been fixed.
For me it is RTBC.

  • catch committed 6f5a111 on 10.0.x
    Issue #3259850 by Spokje: Having a deprecated module with non deprecated...

  • catch committed 2b35c80 on 9.4.x
    Issue #3259850 by Spokje: Having a deprecated module with non deprecated...
catch’s picture

Priority: Normal » Major
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.