Problem/Motivation
The patch in #3227033-52: Remove Quick Edit from core where we deprecated Core module quickedit showed that having a deprecated Core module with dependency on non-deprecated modules lead to a test failure in Drupal\Tests\system\Functional\Module\InstallUninstallTest .
Steps to reproduce
- Make a core module deprecated by adding to appropriated lifecyle parameters in its .info.yml file.
- Weep whilst looking at the test failure:
There was 1 error:
1) Drupal\Tests\system\Functional\Module\InstallUninstallTest::testInstallUninstall
Behat\Mink\Exception\ResponseTextException: The text "Some required modules must be enabled" was not found anywhere in the text of the current page.
/var/www/html/vendor/behat/mink/src/WebAssert.php:785
/var/www/html/vendor/behat/mink/src/WebAssert.php:262
/var/www/html/core/tests/Drupal/Tests/WebAssert.php:898
/var/www/html/core/modules/system/tests/src/Functional/Module/InstallUninstallTest.php:129
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:726
Remaining tasks
Create MR
Review
Commit
Issue fork drupal-3259850
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3259850-having-a-deprecated
changes, plain diff MR !1699
Comments
Comment #3
spokjeComment #4
spokjeComment #5
spokjeComment #6
spokjeComment #7
daffie commentedAll the code changes look good to me.
The test has been fixed.
For me it is RTBC.
Comment #10
catchCommitted/pushed to 10.0.x and cherry-picked to 9.4.x, thanks!