Fix coding standards [#3259815]

Problem/Motivation

The module has issues with coding standards.

Comment	File	Size	Author
#5	interdiff_2-4.txt	4.43 KB	tmaiochi
#5	3259815-4.patch	7.83 KB	tmaiochi
#2	editablefields-fix_codding_standards-3259815-2.patch	3.82 KB	yurii o.

Issue fork editablefields-3259815

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3259815-fix-coding-standards-2 changes, plain diff MR !25
Check out this branch for the first time

Check out existing branch, if you already have it locally
3259815-fix-coding-standards changes, plain diff MR !24
Check out this branch for the first time

Check out existing branch, if you already have it locally
7.x-1.x compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

21 January 2022 at 15:10

Yurii O. created an issue. See original summary.

Status	File	Size
new	editablefields-fix_codding_standards-3259815-2.patch	3.82 KB

Comment #4

gilmord

🇺🇦Ukraine

commented 24 January 2022 at 13:41

@Yurii O. patches is the old way to resolve the issues
please follow a new forks & MRs guide and create a merge request

thanks!

Comment #5

tmaiochi commented 24 January 2022 at 14:01

Assigned:

tmaiochi

» Unassigned

Status	File	Size
new	3259815-4.patch	7.83 KB
new	interdiff_2-4.txt	4.43 KB

The patch had some phpcs problems. I fixed some of them, but it has a warning about unused variable, however the variable is in using. So I left it at that and didn't change anything about this warning. I also sending the interdiff.