Problem/Motivation

The module has issues with coding standards.

CommentFileSizeAuthor
#7 diff_3259589_6-7.txt2.29 KBandregp
#7 3259589-7.patch12.86 KBandregp
#6 3259589-6.patch11.92 KBvictoria-marina
#6 interdiff_2-6.txt1.45 KBvictoria-marina
#2 commerce_liqpay-fix_codding_standards-3259589-2.patch10.7 KByurii o.

Issue fork commerce_liqpay-3259589

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Yurii O. created an issue. See original summary.

yurii o.’s picture

yurii o. commented
Status: Active » Needs review
StatusFileSize
new commerce_liqpay-fix_codding_standards-3259589-2.patch10.7 KB

I made changes, check pls

yurii o.’s picture

yurii o. commented
yurii o.’s picture

yurii o. commented
Project: Rabbit Hole » Commerce Liqpay
Version: 2.x-dev » 8.x-1.x-dev
victoria-marina’s picture

victoria-marina commented
Assigned: Unassigned » victoria-marina
Status: Needs review » Needs work
victoria-marina’s picture

victoria-marina commented
Assigned: victoria-marina » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff_2-6.txt1.45 KB
new 3259589-6.patch11.92 KB

There were still some errors after the #2 and I've fixed them, except this one:

FILE: commerce_liqpay/commerce_liqpay.module
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------
  8 | WARNING | Global constants should not be used, move it to a class or interface
  9 | WARNING | Global constants should not be used, move it to a class or interface
 10 | WARNING | Global constants should not be used, move it to a class or interface
--------------------------------------------------------------------------------------------------------------
andregp’s picture

andregp commented
StatusFileSize
new 3259589-7.patch12.86 KB
new diff_3259589_6-7.txt2.29 KB

Thanks @Yurii O. an @victoria-marina for working on this. Here are the last fixes.

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll do the review.

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned
Status: Needs review » Reviewed & tested by the community

Steps performed:
(1) Installed module
(2) Reproduced the issue.
(3) Applied patch.
(4) Code review on changes.
(5) Tested again with patch, issue resolved.
The patch #7 fixed all messages from PHPCS correctly and the module is working as far as I can test.

ReINFaTe made their first commit to this issue’s fork.

reinfate’s picture

reinfate commented
Assigned: Unassigned » reinfate
Status: Reviewed & tested by the community » Needs work

ReINFaTe opened merge request !1

  • bohart committed a6eaf6c1 on 2.0.x authored by ReINFaTe 
    Issue #3259589 by ReINFaTe, victoria-marina, andregp, Yurii O., tmaiochi...
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Assigned: reinfate » Unassigned
Status: Needs work » Fixed
Issue tags: +Coding standards

Committed to a brand new 2.0.x branch (D10 branch).

Thanks, @all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.